Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1458518 > unrolled thread

4.8-rc1: resume from hibernation doesn't work

Back to article view | Back to linux.kernel

Contents

  4.8-rc1: resume from hibernation doesn't work Jiri Kosina <jikos@kernel.org> - 2016-08-09 10:50 +0200
    Re: 4.8-rc1: resume from hibernation doesn't work Jiri Kosina <jikos@kernel.org> - 2016-08-09 11:00 +0200
      Re: 4.8-rc1: resume from hibernation doesn't work Pavel Machek <pavel@ucw.cz> - 2016-08-09 22:20 +0200
        Re: 4.8-rc1: resume from hibernation doesn't work Jiri Kosina <jikos@kernel.org> - 2016-08-09 22:20 +0200

#1458518 — 4.8-rc1: resume from hibernation doesn't work

Hi,

current Linus' tree (HEAD 65ea11ec6, so basically 4.8-rc1+) has broken 
resume from hibernation on my x200s.

Suspend works correctly, resuming proceeds up to the point where it 
reports 100% of reading of the hibernation image, and afterwards the 
machine reboots (tripple fault ... dunno, I don't really see any kernel 
messages between the report of reading the hibernation image and reboot).

4.7-rc4 is fine on this machine, so I thought I'd bisect it, but 
unfortunately at some point in the bisection process, the hibernation 
itself breaks, so there is not really a way for me to bisect it.

Any ideas which patches to try to revert?

Thanks,

-- 
Jiri Kosina
SUSE Labs

[toc] | [next] | [standalone]

#1458525

On Tue, 9 Aug 2016, Jiri Kosina wrote:

> current Linus' tree (HEAD 65ea11ec6, so basically 4.8-rc1+) has broken 
> resume from hibernation on my x200s.
> 
> Suspend works correctly, resuming proceeds up to the point where it 
> reports 100% of reading of the hibernation image, and afterwards the 
> machine reboots (tripple fault ... dunno, I don't really see any kernel 
> messages between the report of reading the hibernation image and reboot).
> 
> 4.7-rc4 is fine on this machine, so I thought I'd bisect it, but 
> unfortunately at some point in the bisection process, the hibernation 
> itself breaks, so there is not really a way for me to bisect it.
> 
> Any ideas which patches to try to revert?

Okay, turning off CONFIG_RANDOMIZE_MEMORY makes the problem go away and 
machine resumes properly (and yes, I am running a kernel that already 
contains c226fab474).

Adding Thomas Garnier to CC as well.

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [next] | [standalone]

#1459095

On Tue 2016-08-09 10:54:15, Jiri Kosina wrote:
> On Tue, 9 Aug 2016, Jiri Kosina wrote:
> 
> > current Linus' tree (HEAD 65ea11ec6, so basically 4.8-rc1+) has broken 
> > resume from hibernation on my x200s.
> > 
> > Suspend works correctly, resuming proceeds up to the point where it 
> > reports 100% of reading of the hibernation image, and afterwards the 
> > machine reboots (tripple fault ... dunno, I don't really see any kernel 
> > messages between the report of reading the hibernation image and reboot).
> > 
> > 4.7-rc4 is fine on this machine, so I thought I'd bisect it, but 
> > unfortunately at some point in the bisection process, the hibernation 
> > itself breaks, so there is not really a way for me to bisect it.
> > 
> > Any ideas which patches to try to revert?
> 
> Okay, turning off CONFIG_RANDOMIZE_MEMORY makes the problem go away and 
> machine resumes properly (and yes, I am running a kernel that already 
> contains c226fab474).
> 
> Adding Thomas Garnier to CC as well.

64-bit kernel, I assume?

I believe that is known:

From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Thomas Garnier <thgarnie@google.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Borislav Petkov <bp@suse.de>, "Rafael J. Wysocki"
       	<rjw@rjwysocki.net>, Linux PM list <linux-pm@vger.kernel.org>, the arch/x86 maintainers
        <x86@kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Yinghai Lu
       	<yinghai@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar
        <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>, Kees Cook <keescook@chromium.org>,
        Pavel Machek <pavel@ucw.cz>, Kernel Hardening <kernel-hardening@lists.openwall.com>,
        Borislav Petkov <bpetkov@suse.de>
Subject: Re: [Resend][PATCH] x86/power/64: Always create temporary identity mapping correctly
...

>>>> Suggested-by: Yinghai Lu <yinghai@kernel.org>
>>>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>>> Acked-by: Yinghai Lu <yinghai@kernel.org>
>>>> ---
>>>>
>>>> This is sort of urgent, because hibernation doesn't work with KASLR on x86-64
>>>> in 4.8-rc1 AFAICS and this should make them work together again.
>>>>
>>>> Unless anyone sees any problems with it, I'll queue it up for 4.8-rc2.
>>>> 
>>>> Thomas, would it be possible to test it with KASLR enabled, please?

So yes, testing the patch from that thread would be helpful.

Thanks,
										Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[toc] | [prev] | [next] | [standalone]

#1459097

On Mon, 8 Aug 2016, Pavel Machek wrote:

> 64-bit kernel, I assume?
> 
> I believe that is known:
> 
> From: "Rafael J. Wysocki" <rafael@kernel.org>
> To: Thomas Garnier <thgarnie@google.com>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>, Borislav Petkov <bp@suse.de>, "Rafael J. Wysocki"
>        	<rjw@rjwysocki.net>, Linux PM list <linux-pm@vger.kernel.org>, the arch/x86 maintainers
>         <x86@kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Yinghai Lu
>        	<yinghai@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar
>         <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>, Kees Cook <keescook@chromium.org>,
>         Pavel Machek <pavel@ucw.cz>, Kernel Hardening <kernel-hardening@lists.openwall.com>,
>         Borislav Petkov <bpetkov@suse.de>
> Subject: Re: [Resend][PATCH] x86/power/64: Always create temporary identity mapping correctly

Yeah, I've noticed that thread in the meantime and everything is happening 
there now, thanks.

> >>>> Suggested-by: Yinghai Lu <yinghai@kernel.org>
> >>>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >>>> Acked-by: Yinghai Lu <yinghai@kernel.org>
> >>>> ---
> >>>>
> >>>> This is sort of urgent, because hibernation doesn't work with KASLR on x86-64
> >>>> in 4.8-rc1 AFAICS and this should make them work together again.
> >>>>
> >>>> Unless anyone sees any problems with it, I'll queue it up for 4.8-rc2.
> >>>> 
> >>>> Thomas, would it be possible to test it with KASLR enabled, please?
> 
> So yes, testing the patch from that thread would be helpful.

Unfortunately it doesn't fix the issue.

-- 
Jiri Kosina
SUSE Labs

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web