Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1459036 > unrolled thread

[PATCH] x86/mm: minor warning message cleanup

Started byPrarit Bhargava <prarit@redhat.com>
First post2016-08-09 20:00 +0200
Last post2016-08-09 20:50 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] x86/mm: minor warning message cleanup Prarit Bhargava <prarit@redhat.com> - 2016-08-09 20:00 +0200
    Re: [PATCH] x86/mm: minor warning message cleanup Borislav Petkov <bp@suse.de> - 2016-08-09 20:50 +0200

#1459036 — [PATCH] x86/mm: minor warning message cleanup

FromPrarit Bhargava <prarit@redhat.com>
Date2016-08-09 20:00 +0200
Subject[PATCH] x86/mm: minor warning message cleanup
Message-ID<s4jtL-2jZ-1@gated-at.bofh.it>
Capitalize R in RIP.

Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Tony Luck <tony.luck@intel.com>
---
 arch/x86/mm/extable.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/mm/extable.c b/arch/x86/mm/extable.c
index 832b98f822be..bef3aa199f94 100644
--- a/arch/x86/mm/extable.c
+++ b/arch/x86/mm/extable.c
@@ -62,7 +62,7 @@ EXPORT_SYMBOL(ex_handler_rdmsr_unsafe);
 bool ex_handler_wrmsr_unsafe(const struct exception_table_entry *fixup,
 			     struct pt_regs *regs, int trapnr)
 {
-	if (pr_warn_once("unchecked MSR access error: WRMSR to 0x%x (tried to write 0x%08x%08x) at rIP: 0x%lx (%pF)\n",
+	if (pr_warn_once("unchecked MSR access error: WRMSR to 0x%x (tried to write 0x%08x%08x) at RIP: 0x%lx (%pF)\n",
 			 (unsigned int)regs->cx, (unsigned int)regs->dx,
 			 (unsigned int)regs->ax,  regs->ip, (void *)regs->ip))
 		show_stack_regs(regs);
-- 
1.7.9.3

[toc] | [next] | [standalone]


#1459060

FromBorislav Petkov <bp@suse.de>
Date2016-08-09 20:50 +0200
Message-ID<s4kga-2PC-27@gated-at.bofh.it>
In reply to#1459036
On Tue, Aug 09, 2016 at 01:56:31PM -0400, Prarit Bhargava wrote:
> Capitalize R in RIP.
> 
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: x86@kernel.org
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Tony Luck <tony.luck@intel.com>
> ---
>  arch/x86/mm/extable.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/mm/extable.c b/arch/x86/mm/extable.c
> index 832b98f822be..bef3aa199f94 100644
> --- a/arch/x86/mm/extable.c
> +++ b/arch/x86/mm/extable.c
> @@ -62,7 +62,7 @@ EXPORT_SYMBOL(ex_handler_rdmsr_unsafe);
>  bool ex_handler_wrmsr_unsafe(const struct exception_table_entry *fixup,
>  			     struct pt_regs *regs, int trapnr)
>  {
> -	if (pr_warn_once("unchecked MSR access error: WRMSR to 0x%x (tried to write 0x%08x%08x) at rIP: 0x%lx (%pF)\n",
> +	if (pr_warn_once("unchecked MSR access error: WRMSR to 0x%x (tried to write 0x%08x%08x) at RIP: 0x%lx (%pF)\n",

Nope:

rIP:	16-bit, 32-bit, or 64-bit instruction-pointer register. Compare RIP.
RIP:	64-bit instruction-pointer register.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web