Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1458790 > unrolled thread

[PATCH 2/2] ARM: imx6: mark GPC node as not populated after irq init to probe pm domain driver

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 2/2] ARM: imx6: mark GPC node as not populated after irq init to probe pm domain driver Philipp Zabel <p.zabel@pengutronix.de> - 2016-08-09 16:20 +0200
    Re: [PATCH 2/2] ARM: imx6: mark GPC node as not populated after irq  init to probe pm domain driver Rob Herring <robh@kernel.org> - 2016-08-09 19:40 +0200

#1458790 — [PATCH 2/2] ARM: imx6: mark GPC node as not populated after irq init to probe pm domain driver

Since IRQCHIP_DECLARE now flags the GPC node as already populated, the
GPC power domain driver is never probed unless we clear the flag again.

Fixes: 15cc2ed6dcf9 ("of/irq: Mark initialised interrupt controllers as populated")
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Jon Hunter <jonathanh@nvidia.com>
---
 arch/arm/mach-imx/gpc.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/mach-imx/gpc.c b/arch/arm/mach-imx/gpc.c
index fd87205..0df062d 100644
--- a/arch/arm/mach-imx/gpc.c
+++ b/arch/arm/mach-imx/gpc.c
@@ -271,6 +271,12 @@ static int __init imx_gpc_init(struct device_node *node,
 	for (i = 0; i < IMR_NUM; i++)
 		writel_relaxed(~0, gpc_base + GPC_IMR1 + i * 4);
 
+	/*
+	 * Clear the OF_POPULATED flag set in of_irq_init so that
+	 * later the GPC power domain driver will not be skipped.
+	 */
+	of_node_clear_flag(node, OF_POPULATED);
+
 	return 0;
 }
 IRQCHIP_DECLARE(imx_gpc, "fsl,imx6q-gpc", imx_gpc_init);
-- 
2.8.1

[toc] | [next] | [standalone]

#1459028 — Re: [PATCH 2/2] ARM: imx6: mark GPC node as not populated after irq init to probe pm domain driver

On Tue, Aug 09, 2016 at 04:18:52PM +0200, Philipp Zabel wrote:
> Since IRQCHIP_DECLARE now flags the GPC node as already populated, the
> GPC power domain driver is never probed unless we clear the flag again.
> 
> Fixes: 15cc2ed6dcf9 ("of/irq: Mark initialised interrupt controllers as populated")
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Jon Hunter <jonathanh@nvidia.com>
> ---
>  arch/arm/mach-imx/gpc.c | 6 ++++++
>  1 file changed, 6 insertions(+)

I've applied both patches.

Rob

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web