Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1451626 > unrolled thread

[PATCH -next] iommu/amd: Fix error return code in irq_remapping_alloc()

Started byWei Yongjun <weiyj.lk@gmail.com>
First post2016-07-28 04:20 +0200
Last post2016-08-09 17:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH -next] iommu/amd: Fix error return code in irq_remapping_alloc() Wei Yongjun <weiyj.lk@gmail.com> - 2016-07-28 04:20 +0200
    Re: [PATCH -next] iommu/amd: Fix error return code in  irq_remapping_alloc() Joerg Roedel <joro@8bytes.org> - 2016-08-09 17:20 +0200

#1451626 — [PATCH -next] iommu/amd: Fix error return code in irq_remapping_alloc()

FromWei Yongjun <weiyj.lk@gmail.com>
Date2016-07-28 04:20 +0200
Subject[PATCH -next] iommu/amd: Fix error return code in irq_remapping_alloc()
Message-ID<rZJ5v-870-1@gated-at.bofh.it>
Fix to return a negative error code from the alloc_irq_index() error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
 drivers/iommu/amd_iommu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index 96de97a..71e94f3 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -3886,6 +3886,7 @@ static int irq_remapping_alloc(struct irq_domain *domain, unsigned int virq,
 	}
 	if (index < 0) {
 		pr_warn("Failed to allocate IRTE\n");
+		ret = index;
 		goto out_free_parent;
 	}

[toc] | [next] | [standalone]


#1458841 — Re: [PATCH -next] iommu/amd: Fix error return code in irq_remapping_alloc()

FromJoerg Roedel <joro@8bytes.org>
Date2016-08-09 17:20 +0200
SubjectRe: [PATCH -next] iommu/amd: Fix error return code in irq_remapping_alloc()
Message-ID<s4gYW-Rn-25@gated-at.bofh.it>
In reply to#1451626
On Thu, Jul 28, 2016 at 02:10:26AM +0000, Wei Yongjun wrote:
> Fix to return a negative error code from the alloc_irq_index() error
> handling case instead of 0, as done elsewhere in this function.
> 
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>

Applied, thanks.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web