Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1458614 > unrolled thread

[PATCH] video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH] video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails Wolfram Sang <wsa-dev@sang-engineering.com> - 2016-08-09 13:30 +0200
    Re: [PATCH] video: fbdev: mb862xx: mb862xx-i2c: don't print error  when adding adapter fails Wolfram Sang <wsa@the-dreams.de> - 2016-08-10 20:10 +0200
    Re: [PATCH] video: fbdev: mb862xx: mb862xx-i2c: don't print error  when adding adapter fails Tomi Valkeinen <tomi.valkeinen@ti.com> - 2016-08-10 21:20 +0200

#1458614 — [PATCH] video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails

The core will do this for us now.

Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
---
 drivers/video/fbdev/mb862xx/mb862xx-i2c.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
index c87e17afb3e2c9..76d206857e3e2c 100644
--- a/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
+++ b/drivers/video/fbdev/mb862xx/mb862xx-i2c.c
@@ -162,12 +162,7 @@ int mb862xx_i2c_init(struct mb862xxfb_par *par)
 	mb862xx_i2c_adapter.algo_data = par;
 	par->adap = &mb862xx_i2c_adapter;
 
-	ret = i2c_add_adapter(par->adap);
-	if (ret < 0) {
-		dev_err(par->dev, "failed to add %s\n",
-			mb862xx_i2c_adapter.name);
-	}
-	return ret;
+	return i2c_add_adapter(par->adap);
 }
 
 void mb862xx_i2c_exit(struct mb862xxfb_par *par)
-- 
2.8.1

[toc] | [next] | [standalone]

#1459341 — Re: [PATCH] video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails

[Multipart message — attachments visible in raw view] — view raw

> One comment: the patch description should be "stand-alone" text, not a
> continuation of the subject. I fixed this.

I see. Will keep that in mind for the future. Thanks!

[toc] | [prev] | [next] | [standalone]

#1459641 — Re: [PATCH] video: fbdev: mb862xx: mb862xx-i2c: don't print error when adding adapter fails

[Multipart message — attachments visible in raw view] — view raw

On 09/08/16 14:27, Wolfram Sang wrote:
> The core will do this for us now.
> 
> Signed-off-by: Wolfram Sang <wsa-dev@sang-engineering.com>
> ---
>  drivers/video/fbdev/mb862xx/mb862xx-i2c.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

Thanks, queued for v4.9.

One comment: the patch description should be "stand-alone" text, not a
continuation of the subject. I fixed this.

 Tomi

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web