Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1457429 > unrolled thread

Re: [PATCH] ARM: dts: add rk3288-firefly-reload

Started byShawn Lin <shawn.lin@rock-chips.com>
First post2016-08-07 05:50 +0200
Last post2016-08-10 03:20 +0200
Articles 8 — 5 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] ARM: dts: add rk3288-firefly-reload Shawn Lin <shawn.lin@rock-chips.com> - 2016-08-07 05:50 +0200
    Re: [PATCH] ARM: dts: add rk3288-firefly-reload Heiko Stuebner <heiko@sntech.de> - 2016-08-07 16:50 +0200
      Re: [PATCH] ARM: dts: add rk3288-firefly-reload Shawn Lin <shawn.lin@rock-chips.com> - 2016-08-08 04:40 +0200
      Re: [PATCH] ARM: dts: add rk3288-firefly-reload 陈豪 <jacobchen110@gmail.com> - 2016-08-09 11:30 +0200
        Re: [PATCH] ARM: dts: add rk3288-firefly-reload 陈豪 <jacobchen110@gmail.com> - 2016-08-09 12:10 +0200
          Re: [PATCH] ARM: dts: add rk3288-firefly-reload Randy Li <randy.li@rock-chips.com> - 2016-08-09 12:10 +0200
            Re: [PATCH] ARM: dts: add rk3288-firefly-reload Heiko Stübner <heiko@sntech.de> - 2016-08-09 13:00 +0200
              Re: [PATCH] ARM: dts: add rk3288-firefly-reload Randy Li <randy.li@rock-chips.com> - 2016-08-10 03:20 +0200

#1457429 — Re: [PATCH] ARM: dts: add rk3288-firefly-reload

FromShawn Lin <shawn.lin@rock-chips.com>
Date2016-08-07 05:50 +0200
SubjectRe: [PATCH] ARM: dts: add rk3288-firefly-reload
Message-ID<s3ng6-6Je-7@gated-at.bofh.it>
On 2016/7/19 3:46, Heiko Stübner wrote:
> Am Montag, 18. Juli 2016, 23:32:32 schrieb Randy Li:
>> The Firefly RK3288 Reload is a combination Firefly rk3288 core board
>> with the Reload baseboard. Add a dtsi for the Firefly rk3288 core
>> which can be included into the dts for the various baseboards
>> in the future and dts for Reload base board.
>>
>> Currently supported are serial console, wired networking, eMMC and
>> SD storage, SPFIF, IR receiver, LEDs, SDIO wifi and USB. But only
>> the OTG could work on the host mode now, the other USB host can't
>> work now, additional patches are required.
>>
>> Signed-off-by: Randy Li <ayaka@soulik.info>
>> Acked-by: Rob Herring <robh@kernel.org>
>
> applied [0], after some minor reordering - please double check.
>
> Also, while the branch is named 4.8 this will only go into 4.9, as the merge-
> window supposedly opens on the weekend.

Sorry for the noise here:), but I find there is some mmc stuff
which confuse me. Maybe Randy could elaborate more?

Your sdmmc claims to support UHS-I mode like sd-uhs-sdr104, etc, which
will ask dw_mmc to switch vqmmc from 3V3 to 1V8 after sending CMD11.

But the vqmmc is vccio_sd which is fixed as 3V3? :)


>
>
> Heiko
>
> [0] https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?id=e00fdd4931ea4c47f53cba59b7a3800677546bea
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>


-- 
Best Regards
Shawn Lin

[toc] | [next] | [standalone]


#1457461

FromHeiko Stuebner <heiko@sntech.de>
Date2016-08-07 16:50 +0200
Message-ID<s3xyN-53g-5@gated-at.bofh.it>
In reply to#1457429
Hi Shawn,

Am Sonntag, 7. August 2016, 11:40:21 schrieb Shawn Lin:
> On 2016/7/19 3:46, Heiko Stübner wrote:
> > Am Montag, 18. Juli 2016, 23:32:32 schrieb Randy Li:
> >> The Firefly RK3288 Reload is a combination Firefly rk3288 core board
> >> with the Reload baseboard. Add a dtsi for the Firefly rk3288 core
> >> which can be included into the dts for the various baseboards
> >> in the future and dts for Reload base board.
> >> 
> >> Currently supported are serial console, wired networking, eMMC and
> >> SD storage, SPFIF, IR receiver, LEDs, SDIO wifi and USB. But only
> >> the OTG could work on the host mode now, the other USB host can't
> >> work now, additional patches are required.
> >> 
> >> Signed-off-by: Randy Li <ayaka@soulik.info>
> >> Acked-by: Rob Herring <robh@kernel.org>
> > 
> > applied [0], after some minor reordering - please double check.
> > 
> > Also, while the branch is named 4.8 this will only go into 4.9, as the
> > merge- window supposedly opens on the weekend.
> 
> Sorry for the noise here:), but I find there is some mmc stuff
> which confuse me. Maybe Randy could elaborate more?
> 
> Your sdmmc claims to support UHS-I mode like sd-uhs-sdr104, etc, which
> will ask dw_mmc to switch vqmmc from 3V3 to 1V8 after sending CMD11.
> 
> But the vqmmc is vccio_sd which is fixed as 3V3? :)

so far we have only been able to achieve UHS speeds on devices based on the 
rk808 pmic (I had sucess on veyron and popmetal). The act8846-based boards 
seem to have some issue when trying to do the switch to 1.8V, resulting in 
mmc errors and the mmc-core switching back to 3.3V.

I think this might be caused by a bug in the act8846 driver or some dts 
mistake. But so far nobody had the time and enthusiasm to investigate :-)


Heiko

[toc] | [prev] | [next] | [standalone]


#1457517

FromShawn Lin <shawn.lin@rock-chips.com>
Date2016-08-08 04:40 +0200
Message-ID<s3IDT-3M6-1@gated-at.bofh.it>
In reply to#1457461
在 2016/8/7 22:44, Heiko Stuebner 写道:
> Hi Shawn,
>
> Am Sonntag, 7. August 2016, 11:40:21 schrieb Shawn Lin:
>> On 2016/7/19 3:46, Heiko Stübner wrote:
>>> Am Montag, 18. Juli 2016, 23:32:32 schrieb Randy Li:
>>>> The Firefly RK3288 Reload is a combination Firefly rk3288 core board
>>>> with the Reload baseboard. Add a dtsi for the Firefly rk3288 core
>>>> which can be included into the dts for the various baseboards
>>>> in the future and dts for Reload base board.
>>>>
>>>> Currently supported are serial console, wired networking, eMMC and
>>>> SD storage, SPFIF, IR receiver, LEDs, SDIO wifi and USB. But only
>>>> the OTG could work on the host mode now, the other USB host can't
>>>> work now, additional patches are required.
>>>>
>>>> Signed-off-by: Randy Li <ayaka@soulik.info>
>>>> Acked-by: Rob Herring <robh@kernel.org>
>>>
>>> applied [0], after some minor reordering - please double check.
>>>
>>> Also, while the branch is named 4.8 this will only go into 4.9, as the
>>> merge- window supposedly opens on the weekend.
>>
>> Sorry for the noise here:), but I find there is some mmc stuff
>> which confuse me. Maybe Randy could elaborate more?
>>
>> Your sdmmc claims to support UHS-I mode like sd-uhs-sdr104, etc, which
>> will ask dw_mmc to switch vqmmc from 3V3 to 1V8 after sending CMD11.
>>
>> But the vqmmc is vccio_sd which is fixed as 3V3? :)
>
> so far we have only been able to achieve UHS speeds on devices based on the
> rk808 pmic (I had sucess on veyron and popmetal). The act8846-based boards
> seem to have some issue when trying to do the switch to 1.8V, resulting in
> mmc errors and the mmc-core switching back to 3.3V.

Interesting.... I will have a look at it this weekend with Randy face 2
face....

>
> I think this might be caused by a bug in the act8846 driver or some dts
> mistake. But so far nobody had the time and enthusiasm to investigate :-)
>
>
> Heiko
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
>


-- 
Best Regards
Shawn Lin

[toc] | [prev] | [next] | [standalone]


#1458540

From陈豪 <jacobchen110@gmail.com>
Date2016-08-09 11:30 +0200
Message-ID<s4bwd-5Ex-9@gated-at.bofh.it>
In reply to#1457461
2016-08-07 22:44 GMT+08:00 Heiko Stuebner <heiko@sntech.de>:
> Hi Shawn,
>
> Am Sonntag, 7. August 2016, 11:40:21 schrieb Shawn Lin:
>> On 2016/7/19 3:46, Heiko Stübner wrote:
>> > Am Montag, 18. Juli 2016, 23:32:32 schrieb Randy Li:
>> >> The Firefly RK3288 Reload is a combination Firefly rk3288 core board
>> >> with the Reload baseboard. Add a dtsi for the Firefly rk3288 core
>> >> which can be included into the dts for the various baseboards
>> >> in the future and dts for Reload base board.
>> >>
>> >> Currently supported are serial console, wired networking, eMMC and
>> >> SD storage, SPFIF, IR receiver, LEDs, SDIO wifi and USB. But only
>> >> the OTG could work on the host mode now, the other USB host can't
>> >> work now, additional patches are required.
>> >>
>> >> Signed-off-by: Randy Li <ayaka@soulik.info>
>> >> Acked-by: Rob Herring <robh@kernel.org>
>> >
>> > applied [0], after some minor reordering - please double check.
>> >
>> > Also, while the branch is named 4.8 this will only go into 4.9, as the
>> > merge- window supposedly opens on the weekend.
>>
>> Sorry for the noise here:), but I find there is some mmc stuff
>> which confuse me. Maybe Randy could elaborate more?
>>
>> Your sdmmc claims to support UHS-I mode like sd-uhs-sdr104, etc, which
>> will ask dw_mmc to switch vqmmc from 3V3 to 1V8 after sending CMD11.
>>
>> But the vqmmc is vccio_sd which is fixed as 3V3? :)
>
> so far we have only been able to achieve UHS speeds on devices based on the
> rk808 pmic (I had sucess on veyron and popmetal). The act8846-based boards
> seem to have some issue when trying to do the switch to 1.8V, resulting in
> mmc errors and the mmc-core switching back to 3.3V.
>
> I think this might be caused by a bug in the act8846 driver or some dts
> mistake. But so far nobody had the time and enthusiasm to investigate :-)
>
>
> Heiko

Hi all,
sdcard-supply must be specifed  in io-domains node to enable uhs.

io-domains {
compatible = "rockchip,rk3288-io-voltage-domain";
rockchip,grf = <&grf>;
sdcard-supply = <&vccio_sd>;
wifi-supply = <&vcc_18>;
};

[toc] | [prev] | [next] | [standalone]


#1458562

From陈豪 <jacobchen110@gmail.com>
Date2016-08-09 12:10 +0200
Message-ID<s4c8V-6b7-1@gated-at.bofh.it>
In reply to#1458540
well,it has already been added....

The root cause is not act8846. Firefly have a bug with sdmmc and it
seems they didn't fix it in firefly-reload.

http://bbs.t-firefly.com/forum.php?mod=viewthread&tid=256

[toc] | [prev] | [next] | [standalone]


#1458569

FromRandy Li <randy.li@rock-chips.com>
Date2016-08-09 12:10 +0200
Message-ID<s4c8V-6b7-27@gated-at.bofh.it>
In reply to#1458562

從我的 iPad 傳送

> 陈豪 <jacobchen110@gmail.com> 於 2016年8月9日 下午6:02 寫道:
> 
> well,it has already been added....
> 
> The root cause is not act8846. Firefly have a bug with sdmmc and it
> seems they didn't fix it in firefly-reload.
> 
> http://bbs.t-firefly.com/forum.php?mod=viewthread&tid=256
Yes, Jacob is right. Those high speed options need the voltage down to 1.8v. They should be removed.

[toc] | [prev] | [next] | [standalone]


#1458602

FromHeiko Stübner <heiko@sntech.de>
Date2016-08-09 13:00 +0200
Message-ID<s4cVj-6rN-13@gated-at.bofh.it>
In reply to#1458569
Am Dienstag, 9. August 2016, 18:06:33 schrieb Randy Li:
> 從我的 iPad 傳送
> 
> > 陈豪 <jacobchen110@gmail.com> 於 2016年8月9日 下午6:02 寫道:
> > 
> > well,it has already been added....
> > 
> > The root cause is not act8846. Firefly have a bug with sdmmc and it
> > seems they didn't fix it in firefly-reload.
> > 
> > http://bbs.t-firefly.com/forum.php?mod=viewthread&tid=256

Thanks Jacob for pointing out this issue - I was always wondering why it 
wasn't working :-) .


> Yes, Jacob is right. Those high speed options need the voltage down to 1.8v.
> They should be removed.

Randy, can you provide a follow-up patch that removes these excess properties 
please?


Thanks
Heiko

[toc] | [prev] | [next] | [standalone]


#1459233

FromRandy Li <randy.li@rock-chips.com>
Date2016-08-10 03:20 +0200
Message-ID<s4qlz-6S2-11@gated-at.bofh.it>
In reply to#1458602

On 08/09/2016 06:58 PM, Heiko Stübner wrote:
> Am Dienstag, 9. August 2016, 18:06:33 schrieb Randy Li:
>> 從我的 iPad 傳送
>>
>>> 陈豪 <jacobchen110@gmail.com> 於 2016年8月9日 下午6:02 寫道:
>>>
>>> well,it has already been added....
>>>
>>> The root cause is not act8846. Firefly have a bug with sdmmc and it
>>> seems they didn't fix it in firefly-reload.
>>>
>>> http://bbs.t-firefly.com/forum.php?mod=viewthread&tid=256
> Thanks Jacob for pointing out this issue - I was always wondering why it
> wasn't working :-) .
>
>
>> Yes, Jacob is right. Those high speed options need the voltage down to 1.8v.
>> They should be removed.
> Randy, can you provide a follow-up patch that removes these excess properties
> please?
I will send a patch in weekend. I need some time to confirm whether
the sdio wifi would meet the same problem in firefly reload.
I found those patches are not been merged yet, should I just send
a new version or just a patch remove those incorrect excess properties?
>
>
> Thanks
> Heiko
>

-- 
Randy Li
The third produce department

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web