Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1460227 > unrolled thread
| Started by | "Kang, Luwei" <luwei.kang@intel.com> |
|---|---|
| First post | 2016-08-11 09:40 +0200 |
| Last post | 2016-08-11 16:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
RE: [PATCH] KVM: x86: Expose more Intel AVX512 feature to guest "Kang, Luwei" <luwei.kang@intel.com> - 2016-08-11 09:40 +0200
Re: [PATCH] KVM: x86: Expose more Intel AVX512 feature to guest Paolo Bonzini <pbonzini@redhat.com> - 2016-08-11 15:30 +0200
Re: [PATCH] KVM: x86: Expose more Intel AVX512 feature to guest Radim Krčmář <rkrcmar@redhat.com> - 2016-08-11 16:50 +0200
| From | "Kang, Luwei" <luwei.kang@intel.com> |
|---|---|
| Date | 2016-08-11 09:40 +0200 |
| Subject | RE: [PATCH] KVM: x86: Expose more Intel AVX512 feature to guest |
| Message-ID | <s4SKS-O0-27@gated-at.bofh.it> |
> Expose AVX512DQ, AVX512BW, AVX512VL feature to guest.
> Its spec can be found at:
> https://software.intel.com/sites/default/files/managed/b4/3a/319433-024.pdf
>
> Signed-off-by: Luwei Kang <luwei.kang@intel.com>
> ---
> arch/x86/kvm/cpuid.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index 7597b42..a2d007c 100644
> --- a/arch/x86/kvm/cpuid.c
> +++ b/arch/x86/kvm/cpuid.c
> @@ -366,7 +366,8 @@ static inline int __do_cpuid_ent(struct kvm_cpuid_entry2 *entry, u32 function,
> F(FSGSBASE) | F(BMI1) | F(HLE) | F(AVX2) | F(SMEP) |
> F(BMI2) | F(ERMS) | f_invpcid | F(RTM) | f_mpx | F(RDSEED) |
> F(ADX) | F(SMAP) | F(AVX512F) | F(AVX512PF) | F(AVX512ER) |
> - F(AVX512CD) | F(CLFLUSHOPT) | F(CLWB) | F(PCOMMIT);
> + F(AVX512CD) | F(CLFLUSHOPT) | F(CLWB) | F(PCOMMIT) |
> + F(AVX512DQ) | F(AVX512BW) | F(AVX512VL);
>
Hi Paolo,
What is your opinion?
> /* cpuid 0xD.1.eax */
> const u32 kvm_cpuid_D_1_eax_x86_features =
> --
> 2.7.4
[toc] | [next] | [standalone]
| From | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| Date | 2016-08-11 15:30 +0200 |
| Message-ID | <s4Ydz-4ms-3@gated-at.bofh.it> |
| In reply to | #1460227 |
> > Expose AVX512DQ, AVX512BW, AVX512VL feature to guest. > > Its spec can be found at: > > https://software.intel.com/sites/default/files/managed/b4/3a/319433-024.pdf > > > > Signed-off-by: Luwei Kang <luwei.kang@intel.com> > > --- > > arch/x86/kvm/cpuid.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index > > 7597b42..a2d007c 100644 > > --- a/arch/x86/kvm/cpuid.c > > +++ b/arch/x86/kvm/cpuid.c > > @@ -366,7 +366,8 @@ static inline int __do_cpuid_ent(struct > > kvm_cpuid_entry2 *entry, u32 function, > > F(FSGSBASE) | F(BMI1) | F(HLE) | F(AVX2) | F(SMEP) | > > F(BMI2) | F(ERMS) | f_invpcid | F(RTM) | f_mpx | F(RDSEED) | > > F(ADX) | F(SMAP) | F(AVX512F) | F(AVX512PF) | F(AVX512ER) | > > - F(AVX512CD) | F(CLFLUSHOPT) | F(CLWB) | F(PCOMMIT); > > + F(AVX512CD) | F(CLFLUSHOPT) | F(CLWB) | F(PCOMMIT) | > > + F(AVX512DQ) | F(AVX512BW) | F(AVX512VL); > > > > Hi Paolo, > What is your opinion? Hi, the patch was sent too late for 4.8 so I just ignored it. :) Radim is handling the tree now and I guess he'll get to it in the next few days. It's a trivial patch, so I don't expect any issue. Paolo
[toc] | [prev] | [next] | [standalone]
| From | Radim Krčmář <rkrcmar@redhat.com> |
|---|---|
| Date | 2016-08-11 16:50 +0200 |
| Message-ID | <s4ZsZ-54X-3@gated-at.bofh.it> |
| In reply to | #1460514 |
2016-08-11 09:24-0400, Paolo Bonzini:
>> > Expose AVX512DQ, AVX512BW, AVX512VL feature to guest.
>> > Its spec can be found at:
>> > https://software.intel.com/sites/default/files/managed/b4/3a/319433-024.pdf
>> >
>> > Signed-off-by: Luwei Kang <luwei.kang@intel.com>
>> > ---
>> > arch/x86/kvm/cpuid.c | 3 ++-
>> > 1 file changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index
>> > 7597b42..a2d007c 100644
>> > --- a/arch/x86/kvm/cpuid.c
>> > +++ b/arch/x86/kvm/cpuid.c
>> > @@ -366,7 +366,8 @@ static inline int __do_cpuid_ent(struct
>> > kvm_cpuid_entry2 *entry, u32 function,
>> > F(FSGSBASE) | F(BMI1) | F(HLE) | F(AVX2) | F(SMEP) |
>> > F(BMI2) | F(ERMS) | f_invpcid | F(RTM) | f_mpx | F(RDSEED) |
>> > F(ADX) | F(SMAP) | F(AVX512F) | F(AVX512PF) | F(AVX512ER) |
>> > - F(AVX512CD) | F(CLFLUSHOPT) | F(CLWB) | F(PCOMMIT);
>> > + F(AVX512CD) | F(CLFLUSHOPT) | F(CLWB) | F(PCOMMIT) |
>> > + F(AVX512DQ) | F(AVX512BW) | F(AVX512VL);
>> >
>>
>> Hi Paolo,
>> What is your opinion?
>
> Hi, the patch was sent too late for 4.8 so I just ignored it. :) Radim
> is handling the tree now and I guess he'll get to it in the next few
> days. It's a trivial patch, so I don't expect any issue.
F(PCOMMIT) was removed in dfa169bbee00 ("Revert "KVM: x86: add pcommit
support""), so the patch doesn't apply.
I made minor changes (see below) and queued for 4.9, thanks.
- F(AVX512CD) | F(CLFLUSHOPT) | F(CLWB);
+ F(AVX512CD) | F(CLFLUSHOPT) | F(CLWB) | F(AVX512DQ) |
+ F(AVX512BW) | F(AVX512VL);
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web