Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1460392 > unrolled thread

[PATCH] PM / Domains: Always enable debugfs support if available

Back to article view | Back to linux.kernel

Contents

  [PATCH] PM / Domains: Always enable debugfs support if available Jon Hunter <jonathanh@nvidia.com> - 2016-08-11 12:50 +0200
    Re: [PATCH] PM / Domains: Always enable debugfs support if available Geert Uytterhoeven <geert@linux-m68k.org> - 2016-08-11 13:20 +0200
    Re: [PATCH] PM / Domains: Always enable debugfs support if available Ulf Hansson <ulf.hansson@linaro.org> - 2016-08-19 13:40 +0200

#1460392 — [PATCH] PM / Domains: Always enable debugfs support if available

Debugfs support for PM domains is only enabled if both CONFIG_PM_DEBUG
and CONFIG_PM_ADVANCED_DEBUG are enabled. CONFIG_PM_ADVANCED_DEBUG is
described as "extra PM attributes in sysfs for low-level
debugging/testing" which does not seem related.

Given that the debugfs for PM domains only allows users to view the
state of the PM domains, always enable debugfs support for PM domains
if PM domains and debugfs support is enabled.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
 drivers/base/power/domain.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
index a1f2aff33997..058c8b6d2871 100644
--- a/drivers/base/power/domain.c
+++ b/drivers/base/power/domain.c
@@ -1636,7 +1636,7 @@ EXPORT_SYMBOL_GPL(genpd_dev_pm_attach);
 
 /***        debugfs support        ***/
 
-#ifdef CONFIG_PM_ADVANCED_DEBUG
+#ifdef CONFIG_DEBUG_FS
 #include <linux/pm.h>
 #include <linux/device.h>
 #include <linux/debugfs.h>
@@ -1784,4 +1784,4 @@ static void __exit pm_genpd_debug_exit(void)
 	debugfs_remove_recursive(pm_genpd_debugfs_dir);
 }
 __exitcall(pm_genpd_debug_exit);
-#endif /* CONFIG_PM_ADVANCED_DEBUG */
+#endif /* CONFIG_DEBUG_FS */
-- 
2.1.4

[toc] | [next] | [standalone]

#1460408

On Thu, Aug 11, 2016 at 12:40 PM, Jon Hunter <jonathanh@nvidia.com> wrote:
> Debugfs support for PM domains is only enabled if both CONFIG_PM_DEBUG
> and CONFIG_PM_ADVANCED_DEBUG are enabled. CONFIG_PM_ADVANCED_DEBUG is
> described as "extra PM attributes in sysfs for low-level
> debugging/testing" which does not seem related.
>
> Given that the debugfs for PM domains only allows users to view the
> state of the PM domains, always enable debugfs support for PM domains
> if PM domains and debugfs support is enabled.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[toc] | [prev] | [next] | [standalone]

#1466305

On 11 August 2016 at 12:40, Jon Hunter <jonathanh@nvidia.com> wrote:
> Debugfs support for PM domains is only enabled if both CONFIG_PM_DEBUG
> and CONFIG_PM_ADVANCED_DEBUG are enabled. CONFIG_PM_ADVANCED_DEBUG is
> described as "extra PM attributes in sysfs for low-level
> debugging/testing" which does not seem related.
>
> Given that the debugfs for PM domains only allows users to view the
> state of the PM domains, always enable debugfs support for PM domains
> if PM domains and debugfs support is enabled.
>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>

Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

Kind regards
Uffe

> ---
>  drivers/base/power/domain.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index a1f2aff33997..058c8b6d2871 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -1636,7 +1636,7 @@ EXPORT_SYMBOL_GPL(genpd_dev_pm_attach);
>
>  /***        debugfs support        ***/
>
> -#ifdef CONFIG_PM_ADVANCED_DEBUG
> +#ifdef CONFIG_DEBUG_FS
>  #include <linux/pm.h>
>  #include <linux/device.h>
>  #include <linux/debugfs.h>
> @@ -1784,4 +1784,4 @@ static void __exit pm_genpd_debug_exit(void)
>         debugfs_remove_recursive(pm_genpd_debugfs_dir);
>  }
>  __exitcall(pm_genpd_debug_exit);
> -#endif /* CONFIG_PM_ADVANCED_DEBUG */
> +#endif /* CONFIG_DEBUG_FS */
> --
> 2.1.4
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web