Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1460117 > unrolled thread

[PATCH] IB/usnic: Fix error return code

Back to article view | Back to linux.kernel

Contents

  [PATCH] IB/usnic: Fix error return code Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2016-08-11 02:50 +0200
    Re: [PATCH] IB/usnic: Fix error return code Doug Ledford <dledford@redhat.com> - 2016-08-22 20:30 +0200

#1460117 — [PATCH] IB/usnic: Fix error return code

If 'pci_register_driver' fails, we return 'err' which is known to be 0.
Return the error instead.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/infiniband/hw/usnic/usnic_ib_main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/usnic/usnic_ib_main.c b/drivers/infiniband/hw/usnic/usnic_ib_main.c
index c229b9f4a52d..0a89a955550b 100644
--- a/drivers/infiniband/hw/usnic/usnic_ib_main.c
+++ b/drivers/infiniband/hw/usnic/usnic_ib_main.c
@@ -664,7 +664,8 @@ static int __init usnic_ib_init(void)
 		return err;
 	}
 
-	if (pci_register_driver(&usnic_ib_pci_driver)) {
+	err = pci_register_driver(&usnic_ib_pci_driver);
+	if (err) {
 		usnic_err("Unable to register with PCI\n");
 		goto out_umem_fini;
 	}
-- 
2.7.4


---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus

[toc] | [next] | [standalone]

#1467889

[Multipart message — attachments visible in raw view] — view raw

On 8/10/2016 11:45 AM, Christophe JAILLET wrote:
> If 'pci_register_driver' fails, we return 'err' which is known to be 0.
> Return the error instead.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Thanks, applied.


-- 
Doug Ledford <dledford@redhat.com>
    GPG Key ID: 0E572FDD

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web