Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1459150 > unrolled thread

[PATCH 3/4] befs: fix comment style

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 3/4] befs: fix comment style Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-08-10 00:10 +0200
    Re: [PATCH 3/4] befs: fix comment style Salah Triki <salah.triki@gmail.com> - 2016-08-10 23:50 +0200

#1459150 — [PATCH 3/4] befs: fix comment style

The description of befs_load_sb was confusing the kernel-doc system since,
because it starts with /**, it thinks it will document the function with
kernel-doc formatting. Which it isn't.

Fix other comment style issues in the file while we are at it.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
 fs/befs/super.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/fs/befs/super.c b/fs/befs/super.c
index c36745d..80b93c0 100644
--- a/fs/befs/super.c
+++ b/fs/befs/super.c
@@ -13,13 +13,9 @@
 #include "befs.h"
 #include "super.h"
 
-/**
+/*
  * befs_load_sb -- Read from disk and properly byteswap all the fields
  * of the befs superblock
- *
- *
- *
- *
  */
 int
 befs_load_sb(struct super_block *sb, befs_super_block * disk_sb)
@@ -93,8 +89,8 @@ befs_check_sb(struct super_block *sb)
 	}
 
 	/*
-	   * block_shift and block_size encode the same information
-	   * in different ways as a consistency check.
+	 * block_shift and block_size encode the same information
+	 * in different ways as a consistency check.
 	 */
 
 	if ((1 << befs_sb->block_shift) != befs_sb->block_size) {
-- 
2.5.1

[toc] | [next] | [standalone]

#1460022

On Tue, Aug 09, 2016 at 11:01:25PM +0100, Luis de Bethencourt wrote:
> The description of befs_load_sb was confusing the kernel-doc system since,
> because it starts with /**, it thinks it will document the function with
> kernel-doc formatting. Which it isn't.
> 
> Fix other comment style issues in the file while we are at it.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>  fs/befs/super.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/fs/befs/super.c b/fs/befs/super.c
> index c36745d..80b93c0 100644
> --- a/fs/befs/super.c
> +++ b/fs/befs/super.c
> @@ -13,13 +13,9 @@
>  #include "befs.h"
>  #include "super.h"
>  
> -/**
> +/*
>   * befs_load_sb -- Read from disk and properly byteswap all the fields
>   * of the befs superblock
> - *
> - *
> - *
> - *
>   */
>  int
>  befs_load_sb(struct super_block *sb, befs_super_block * disk_sb)
> @@ -93,8 +89,8 @@ befs_check_sb(struct super_block *sb)
>  	}
>  
>  	/*
> -	   * block_shift and block_size encode the same information
> -	   * in different ways as a consistency check.
> +	 * block_shift and block_size encode the same information
> +	 * in different ways as a consistency check.
>  	 */
>  
>  	if ((1 << befs_sb->block_shift) != befs_sb->block_size) {
> -- 
> 2.5.1
> 

Signed-off-by: Salah Triki <salah.triki@gmail.com>

Thanx
Salah

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web