Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1460000 > unrolled thread

[PATCH] perf: Skip running the feature tests for 'make install-doc'

Back to article view | Back to linux.kernel

Contents

  [PATCH] perf: Skip running the feature tests for 'make install-doc' Rui Teng <rui.teng@linux.vnet.ibm.com> - 2016-08-10 23:40 +0200
    Re: [PATCH] perf: Skip running the feature tests for 'make  install-doc' Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-08-15 18:40 +0200
    [tip:perf/core] perf tools: Skip running the feature tests for  'make install-doc' tip-bot for Rui Teng <tipbot@zytor.com> - 2016-08-24 11:30 +0200

#1460000 — [PATCH] perf: Skip running the feature tests for 'make install-doc'

It is a requirement from the perf todo list:
The feature tests should be performed only when a file that needs those tests,
or at least only when some .c or .h file will be rebuilt
    An initial step would be for 'make install-doc' not to run the feature tests,
    there it is not needed at all.

By adding 'install-doc' to the NON_CONFIG_TARGETS, it will skip running the
feature tests for such target. The Auto-detecting system features list will
not be displayed:

$ make install-doc
  BUILD:   Doing 'make -j2' parallel build
  SUBDIR   Documentation
make[2]: Nothing to be done for 'install'.

Signed-off-by: Rui Teng <rui.teng@linux.vnet.ibm.com>
---
 tools/perf/Makefile.perf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 2d90875..9c1dac6 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -165,7 +165,7 @@ SUBCMD_DIR	= $(srctree)/tools/lib/subcmd/
 # non-config cases
 config := 1
 
-NON_CONFIG_TARGETS := clean TAGS tags cscope help
+NON_CONFIG_TARGETS := clean TAGS tags cscope help install-doc
 
 ifdef MAKECMDGOALS
 ifeq ($(filter-out $(NON_CONFIG_TARGETS),$(MAKECMDGOALS)),)
-- 
2.7.4

[toc] | [next] | [standalone]

#1462980 — Re: [PATCH] perf: Skip running the feature tests for 'make install-doc'

Em Wed, Aug 10, 2016 at 04:49:08PM +0800, Rui Teng escreveu:
> It is a requirement from the perf todo list:
> The feature tests should be performed only when a file that needs those tests,
> or at least only when some .c or .h file will be rebuilt
>     An initial step would be for 'make install-doc' not to run the feature tests,
>     there it is not needed at all.

Thanks for working on that! As soon as I push this out to Ingo I'll move
that entry from the TODO to a DONE section, adding the URL to the cset
where it was done.

Now pick another one! :-)

- Arnaldo
 
> By adding 'install-doc' to the NON_CONFIG_TARGETS, it will skip running the
> feature tests for such target. The Auto-detecting system features list will
> not be displayed:
> 
> $ make install-doc
>   BUILD:   Doing 'make -j2' parallel build
>   SUBDIR   Documentation
> make[2]: Nothing to be done for 'install'.
> 
> Signed-off-by: Rui Teng <rui.teng@linux.vnet.ibm.com>
> ---
>  tools/perf/Makefile.perf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 2d90875..9c1dac6 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -165,7 +165,7 @@ SUBCMD_DIR	= $(srctree)/tools/lib/subcmd/
>  # non-config cases
>  config := 1
>  
> -NON_CONFIG_TARGETS := clean TAGS tags cscope help
> +NON_CONFIG_TARGETS := clean TAGS tags cscope help install-doc
>  
>  ifdef MAKECMDGOALS
>  ifeq ($(filter-out $(NON_CONFIG_TARGETS),$(MAKECMDGOALS)),)
> -- 
> 2.7.4

[toc] | [prev] | [next] | [standalone]

#1469268 — [tip:perf/core] perf tools: Skip running the feature tests for 'make install-doc'

Commit-ID:  11196b79164c95b8e5968ff63fa6b59536c9748f
Gitweb:     http://git.kernel.org/tip/11196b79164c95b8e5968ff63fa6b59536c9748f
Author:     Rui Teng <rui.teng@linux.vnet.ibm.com>
AuthorDate: Wed, 10 Aug 2016 16:49:08 +0800
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 23 Aug 2016 15:37:33 -0300

perf tools: Skip running the feature tests for 'make install-doc'

It is a requirement from the perf TODO list[1]:

''The feature tests should be performed only when a file that needs those
  tests, or at least only when some .c or .h file will be rebuilt. An
  initial step would be for 'make install-doc' not to run the feature
  tests, there it is not needed at all.''

By adding 'install-doc' to the NON_CONFIG_TARGETS, it will skip running
the feature tests for such target. The Auto-detecting system features
list will not be displayed:

  $ make install-doc
    BUILD:   Doing 'make -j2' parallel build
    SUBDIR   Documentation
  make[2]: Nothing to be done for 'install'.

[1] https://perf.wiki.kernel.org/index.php/Todo

Signed-off-by: Rui Teng <rui.teng@linux.vnet.ibm.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1470818948-17784-1-git-send-email-rui.teng@linux.vnet.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Makefile.perf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index aa7ab23..828cfd7 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -165,7 +165,7 @@ SUBCMD_DIR	= $(srctree)/tools/lib/subcmd/
 # non-config cases
 config := 1
 
-NON_CONFIG_TARGETS := clean TAGS tags cscope help
+NON_CONFIG_TARGETS := clean TAGS tags cscope help install-doc
 
 ifdef MAKECMDGOALS
 ifeq ($(filter-out $(NON_CONFIG_TARGETS),$(MAKECMDGOALS)),)

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web