Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1458290 > unrolled thread

[PATCH 1/2] ACPI/tables: Correct the wrong count increasing

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] ACPI/tables: Correct the wrong count increasing Baoquan He <bhe@redhat.com> - 2016-08-09 01:10 +0200
    Re: [PATCH 1/2] ACPI/tables: Correct the wrong count increasing kbuild test robot <lkp@intel.com> - 2016-08-09 01:30 +0200
      Re: [PATCH 1/2] ACPI/tables: Correct the wrong count increasing Baoquan He <bhe@redhat.com> - 2016-08-09 02:30 +0200
    [PATCH v2 1/2] ACPI/tables: Correct the wrong count increasing Baoquan He <bhe@redhat.com> - 2016-08-09 02:40 +0200

#1458290 — [PATCH 1/2] ACPI/tables: Correct the wrong count increasing

The current code always increases the count in the 1st element of
array proc[].

Signed-off-by: Baoquan He <bhe@redhat.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org
---
 drivers/acpi/tables.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index 9f0ad6e..34d45bb 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -281,7 +281,7 @@ acpi_parse_entries_array(char *id, unsigned long table_size,
 			     proc[i].handler(entry, table_end))
 				return -EINVAL;
 
-			proc->count++;
+			proc[i]->count++;
 			break;
 		}
 		if (i != proc_num)
-- 
2.5.5

[toc] | [next] | [standalone]

#1458304

[Multipart message — attachments visible in raw view] — view raw

Hi Baoquan,

[auto build test ERROR on pm/linux-next]
[also build test ERROR on v4.8-rc1 next-20160808]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Baoquan-He/ACPI-tables-Correct-the-wrong-count-increasing/20160809-070345
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: x86_64-randconfig-x002-201632 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/acpi/tables.c: In function 'acpi_parse_entries_array':
>> drivers/acpi/tables.c:284:11: error: invalid type argument of '->' (have 'struct acpi_subtable_proc')
       proc[i]->count++;
              ^~

vim +284 drivers/acpi/tables.c

   278				if (entry->type != proc[i].id)
   279					continue;
   280				if (!proc[i].handler ||
   281				     proc[i].handler(entry, table_end))
   282					return -EINVAL;
   283	
 > 284				proc[i]->count++;
   285				break;
   286			}
   287			if (i != proc_num)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [prev] | [next] | [standalone]

#1458345

Sorry, I tested in another system, but forget updating code on my
laptop.

Will reply with a v2 post.

Sorry again about this mistake.

[toc] | [prev] | [next] | [standalone]

#1458348 — [PATCH v2 1/2] ACPI/tables: Correct the wrong count increasing

The current code always increases the count in the 1st element of
array proc[].

Signed-off-by: Baoquan He <bhe@redhat.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org
---

v1->v2:
    V1 is a wrong post because I didn't update the tested code to my
    local laptop. Repost with a correct v2.

 drivers/acpi/tables.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index 9f0ad6e..34d45bb 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -281,7 +281,7 @@ acpi_parse_entries_array(char *id, unsigned long table_size,
 			     proc[i].handler(entry, table_end))
 				return -EINVAL;
 
-			proc->count++;
+			proc[i].count++;
 			break;
 		}
 		if (i != proc_num)
-- 
2.5.5

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web