Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1458289 > unrolled thread
| Started by | Baoquan He <bhe@redhat.com> |
|---|---|
| First post | 2016-08-09 01:10 +0200 |
| Last post | 2016-08-10 21:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/2] x86, ACPI: Fix the wrong assignment when Handle apic/x2apic entries Baoquan He <bhe@redhat.com> - 2016-08-09 01:10 +0200
Re: [PATCH 2/2] x86, ACPI: Fix the wrong assignment when Handle apic/x2apic entries Ingo Molnar <mingo@kernel.org> - 2016-08-10 21:00 +0200
Re: [PATCH 2/2] x86, ACPI: Fix the wrong assignment when Handle apic/x2apic entries Baoquan He <bhe@redhat.com> - 2016-08-10 21:10 +0200
| From | Baoquan He <bhe@redhat.com> |
|---|---|
| Date | 2016-08-09 01:10 +0200 |
| Subject | [PATCH 2/2] x86, ACPI: Fix the wrong assignment when Handle apic/x2apic entries |
| Message-ID | <s41Qd-7Ui-9@gated-at.bofh.it> |
It won't impact the result, we still should fix the code bug.
Signed-off-by: Baoquan He <bhe@redhat.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <len.brown@intel.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org
Cc: linux-pm@vger.kernel.org
---
arch/x86/kernel/acpi/boot.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index 90d84c3..2b25d3f 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -1031,8 +1031,8 @@ static int __init acpi_parse_madt_lapic_entries(void)
return ret;
}
- x2count = madt_proc[0].count;
- count = madt_proc[1].count;
+ count = madt_proc[0].count;
+ x2count = madt_proc[1].count;
}
if (!count && !x2count) {
printk(KERN_ERR PREFIX "No LAPIC entries present\n");
--
2.5.5
[toc] | [next] | [standalone]
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Date | 2016-08-10 21:00 +0200 |
| Subject | Re: [PATCH 2/2] x86, ACPI: Fix the wrong assignment when Handle apic/x2apic entries |
| Message-ID | <s4GTp-n4-55@gated-at.bofh.it> |
| In reply to | #1458289 |
* Baoquan He <bhe@redhat.com> wrote:
> It won't impact the result, we still should fix the code bug.
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Len Brown <len.brown@intel.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: x86@kernel.org
> Cc: linux-pm@vger.kernel.org
> ---
> arch/x86/kernel/acpi/boot.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
> index 90d84c3..2b25d3f 100644
> --- a/arch/x86/kernel/acpi/boot.c
> +++ b/arch/x86/kernel/acpi/boot.c
> @@ -1031,8 +1031,8 @@ static int __init acpi_parse_madt_lapic_entries(void)
> return ret;
> }
>
> - x2count = madt_proc[0].count;
> - count = madt_proc[1].count;
> + count = madt_proc[0].count;
> + x2count = madt_proc[1].count;
> }
> if (!count && !x2count) {
> printk(KERN_ERR PREFIX "No LAPIC entries present\n");
Why does this bug have no effect?
Thanks,
Ingo
[toc] | [prev] | [next] | [standalone]
| From | Baoquan He <bhe@redhat.com> |
|---|---|
| Date | 2016-08-10 21:10 +0200 |
| Subject | Re: [PATCH 2/2] x86, ACPI: Fix the wrong assignment when Handle apic/x2apic entries |
| Message-ID | <s4H36-I0-89@gated-at.bofh.it> |
| In reply to | #1459547 |
On 08/10/16 at 02:53pm, Ingo Molnar wrote:
>
> * Baoquan He <bhe@redhat.com> wrote:
>
> > It won't impact the result, we still should fix the code bug.
> >
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> > Cc: Len Brown <len.brown@intel.com>
> > Cc: Pavel Machek <pavel@ucw.cz>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > Cc: x86@kernel.org
> > Cc: linux-pm@vger.kernel.org
> > ---
> > arch/x86/kernel/acpi/boot.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
> > index 90d84c3..2b25d3f 100644
> > --- a/arch/x86/kernel/acpi/boot.c
> > +++ b/arch/x86/kernel/acpi/boot.c
> > @@ -1031,8 +1031,8 @@ static int __init acpi_parse_madt_lapic_entries(void)
> > return ret;
> > }
> >
> > - x2count = madt_proc[0].count;
> > - count = madt_proc[1].count;
> > + count = madt_proc[0].count;
> > + x2count = madt_proc[1].count;
> > }
> > if (!count && !x2count) {
~~~~~~~~~~~~~~~~~~~~~
I mean here the value checking won't be impacted by the wrong
assignment.
> > printk(KERN_ERR PREFIX "No LAPIC entries present\n");
>
> Why does this bug have no effect?
>
> Thanks,
>
> Ingo
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web