Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1457891 > unrolled thread
| Started by | robert.foss@collabora.com |
|---|---|
| First post | 2016-08-08 18:20 +0200 |
| Last post | 2016-08-08 18:20 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
[PACTH v2] mmc: sdhci: Do not allow tuning procedure to be interrupted robert.foss@collabora.com - 2016-08-08 18:20 +0200
| From | robert.foss@collabora.com |
|---|---|
| Date | 2016-08-08 18:20 +0200 |
| Subject | [PACTH v2] mmc: sdhci: Do not allow tuning procedure to be interrupted |
| Message-ID | <s3Vrr-3D1-7@gated-at.bofh.it> |
From: Christopher Freeman <cfreeman@nvidia.com> wait_event_interruptible_timeout() will return early if the blocked process receives a signal, causing the driver to abort the tuning procedure and possibly leaving the controller in a bad state. Since the tuning command is expected to complete quickly (<50ms) and we've set a timeout, use wait_event_timeout() instead. Signed-off-by: Christopher Freeman <cfreeman@nvidia.com> Tested-by: Robert Foss <robert.foss@collabora.com> Signed-off-by: Robert Foss <robert.foss@collabora.com> --- This is a resubmission of v2 of this patch. drivers/mmc/host/sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 0e3d7c0..9e80203 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -1960,7 +1960,7 @@ static int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode) spin_unlock_irqrestore(&host->lock, flags); /* Wait for Buffer Read Ready interrupt */ - wait_event_interruptible_timeout(host->buf_ready_int, + wait_event_timeout(host->buf_ready_int, (host->tuning_done == 1), msecs_to_jiffies(50)); spin_lock_irqsave(&host->lock, flags); -- 2.7.4
Back to top | Article view | linux.kernel
csiph-web