Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1457809 > unrolled thread
| Started by | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| First post | 2016-08-08 16:00 +0200 |
| Last post | 2016-08-10 22:20 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] w1: fix timeout_us parameter description Wei Yongjun <weiyj.lk@gmail.com> - 2016-08-08 16:00 +0200
Re: [PATCH] w1: fix timeout_us parameter description Evgeniy Polyakov <zbr@ioremap.net> - 2016-08-10 01:10 +0200
Re: [PATCH] w1: fix timeout_us parameter description Wei Yongjun <weiyj.lk@gmail.com> - 2016-08-10 05:50 +0200
Re: [PATCH] w1: fix timeout_us parameter description Evgeniy Polyakov <zbr@ioremap.net> - 2016-08-10 22:20 +0200
| From | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| Date | 2016-08-08 16:00 +0200 |
| Subject | [PATCH] w1: fix timeout_us parameter description |
| Message-ID | <s3TfX-26k-3@gated-at.bofh.it> |
Fix 'timeout_us' parameter description. Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com> --- drivers/w1/w1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index bb34362..e213c67 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -53,8 +53,8 @@ int w1_max_slave_ttl = 10; module_param_named(timeout, w1_timeout, int, 0); MODULE_PARM_DESC(timeout, "time in seconds between automatic slave searches"); module_param_named(timeout_us, w1_timeout_us, int, 0); -MODULE_PARM_DESC(timeout, "time in microseconds between automatic slave" - " searches"); +MODULE_PARM_DESC(timeout_us, + "time in microseconds between automatic slave searches"); /* A search stops when w1_max_slave_count devices have been found in that * search. The next search will start over and detect the same set of devices * on a static 1-wire bus. Memory is not allocated based on this number, just
[toc] | [next] | [standalone]
| From | Evgeniy Polyakov <zbr@ioremap.net> |
|---|---|
| Date | 2016-08-10 01:10 +0200 |
| Message-ID | <s4ojM-5xv-7@gated-at.bofh.it> |
| In reply to | #1457809 |
Hi 08.08.2016, 16:52, "Wei Yongjun" <weiyj.lk@gmail.com>: > Fix 'timeout_us' parameter description. > > Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com> > --- > drivers/w1/w1.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c > index bb34362..e213c67 100644 > --- a/drivers/w1/w1.c > +++ b/drivers/w1/w1.c > @@ -53,8 +53,8 @@ int w1_max_slave_ttl = 10; > module_param_named(timeout, w1_timeout, int, 0); > MODULE_PARM_DESC(timeout, "time in seconds between automatic slave searches"); > module_param_named(timeout_us, w1_timeout_us, int, 0); > -MODULE_PARM_DESC(timeout, "time in microseconds between automatic slave" > - " searches"); > +MODULE_PARM_DESC(timeout_us, > + "time in microseconds between automatic slave searches"); I believe there will be no harm to put it to on one line, even if it crosses some obscure very-long-line rule
[toc] | [prev] | [next] | [standalone]
| From | Wei Yongjun <weiyj.lk@gmail.com> |
|---|---|
| Date | 2016-08-10 05:50 +0200 |
| Message-ID | <s4sGK-8gB-3@gated-at.bofh.it> |
| In reply to | #1459169 |
Hi On 08/10/2016 06:54 AM, Evgeniy Polyakov wrote: > Hi > > 08.08.2016, 16:52, "Wei Yongjun" <weiyj.lk@gmail.com>: >> Fix 'timeout_us' parameter description. >> >> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com> >> --- >> drivers/w1/w1.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c >> index bb34362..e213c67 100644 >> --- a/drivers/w1/w1.c >> +++ b/drivers/w1/w1.c >> @@ -53,8 +53,8 @@ int w1_max_slave_ttl = 10; >> module_param_named(timeout, w1_timeout, int, 0); >> MODULE_PARM_DESC(timeout, "time in seconds between automatic slave searches"); >> module_param_named(timeout_us, w1_timeout_us, int, 0); >> -MODULE_PARM_DESC(timeout, "time in microseconds between automatic slave" >> - " searches"); >> +MODULE_PARM_DESC(timeout_us, >> + "time in microseconds between automatic slave searches"); > I believe there will be no harm to put it to on one line, even if it crosses some obscure very-long-line rule Maybe the bad patch description confused you, this patch the typo in the first argument of MODULE_PARM_DESC(), use timeout_us instead of timeout.
[toc] | [prev] | [next] | [standalone]
| From | Evgeniy Polyakov <zbr@ioremap.net> |
|---|---|
| Date | 2016-08-10 22:20 +0200 |
| Message-ID | <s4I8O-1sK-39@gated-at.bofh.it> |
| In reply to | #1459272 |
Hi 10.08.2016, 06:22, "Wei Yongjun" <weiyj.lk@gmail.com>: >> 08.08.2016, 16:52, "Wei Yongjun" <weiyj.lk@gmail.com>: >>> Fix 'timeout_us' parameter description. >>> MODULE_PARM_DESC(timeout, "time in seconds between automatic slave searches"); >>> module_param_named(timeout_us, w1_timeout_us, int, 0); >>> -MODULE_PARM_DESC(timeout, "time in microseconds between automatic slave" >>> - " searches"); >>> +MODULE_PARM_DESC(timeout_us, >>> + "time in microseconds between automatic slave searches"); >> I believe there will be no harm to put it to on one line, even if it crosses some obscure very-long-line rule > > Maybe the bad patch description confused you, this patch the typo in the > first argument of MODULE_PARM_DESC(), use timeout_us instead of timeout. Yup, you are right, please make it as one line since you are at it
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web