Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1457529 > unrolled thread

Re: [PATCH] treewide: fix a bunch of typos (part 2)

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] treewide: fix a bunch of typos (part 2) Randy Dunlap <rdunlap@infradead.org> - 2016-08-08 07:00 +0200
    Re: [PATCH] treewide: fix a bunch of typos (part 2) Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-08-08 07:30 +0200
      Re: [PATCH] treewide: fix a bunch of typos (part 2) Randy Dunlap <rdunlap@infradead.org> - 2016-08-08 16:40 +0200

#1457529 — Re: [PATCH] treewide: fix a bunch of typos (part 2)

On 08/07/16 06:56, Masahiro Yamada wrote:
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>


ipc/	: all OK
kernel/	: all OK
lib/	: all OK
scripts/ : all OK
security/ : all OK
tools/	: all OK


block/ comments (otherwise all OK):

--- a/block/scsi_ioctl.c
+++ b/block/scsi_ioctl.c
@@ -468,7 +468,7 @@ int sg_scsi_ioctl(struct request_queue *q, struct gendisk *disk, fmode_t mode,
 	if (err)
 		goto error;
 
-	/* default.  possible overriden later */
+	/* default.  possible overridden later */

* possibly


fs/ comments (otherwise all OK):

--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
  * There are two cases:
- *  a> the extent are splitted into two extent.
+ *  a> the extent are split into two extent.

* into two extents.


mm/ comment (otherwise all OK):

--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5790,7 +5790,7 @@ static unsigned long __paginginit calc_memmap_size(unsigned long spanned_pages,
 	 * the zone and SPARSEMEM is in use. If there are holes within the
 	 * zone, each populated memory region may cost us one or two extra
 	 * memmap pages due to alignment because memmap pages for each
-	 * populated regions may not naturally algined on page boundary.
+	 * populated regions may not naturally aligned on page boundary.

*	                     may not be naturally aligned


net/ comment (otherwise all OK):

--- a/net/sctp/transport.c
+++ b/net/sctp/transport.c
@@ -630,9 +630,7 @@ void sctp_transport_reset(struct sctp_transport *t)
 	t->srtt = 0;
 	t->rttvar = 0;
 
-	/* Reset these additional varibles so that we have a clean
-	 * slate.
-	 */
+	/* Reset these additional variables so that we have a clean state. */

* Nothing wrong with original comment.


sound/ comments (otherwise all OK):

--- a/sound/soc/soc-ac97.c
+++ b/sound/soc/soc-ac97.c
@@ -169,7 +169,7 @@ static void snd_soc_ac97_free_gpio(struct snd_ac97 *ac97)
  * snd_soc_alloc_ac97_codec() - Allocate new a AC'97 device
  * @codec: The CODEC for which to create the AC'97 device
  *
- * Allocated a new snd_ac97 device and intializes it, but does not yet register
+ * Allocated a new snd_ac97 device and initializes it, but does not yet register

* Allocates


---
That covers everything except arch/ and drivers/.

-- 
~Randy

[toc] | [next] | [standalone]

#1457531

Hi Randy,

Thanks for taking a close look!


2016-08-08 13:50 GMT+09:00 Randy Dunlap <rdunlap@infradead.org>:

> --- a/net/sctp/transport.c
> +++ b/net/sctp/transport.c
> @@ -630,9 +630,7 @@ void sctp_transport_reset(struct sctp_transport *t)
>         t->srtt = 0;
>         t->rttvar = 0;
>
> -       /* Reset these additional varibles so that we have a clean
> -        * slate.
> -        */
> +       /* Reset these additional variables so that we have a clean state. */
>
> * Nothing wrong with original comment.


This hunk is doing three things:

 [1] varibles  -> variables
 [2] slate   ->  state
 [3] Make it into a single line


Do you mean they are all unneeded changes?



-- 
Best Regards
Masahiro Yamada

[toc] | [prev] | [next] | [standalone]

#1457838

On 08/07/16 22:20, Masahiro Yamada wrote:
> Hi Randy,
> 
> Thanks for taking a close look!
> 
> 
> 2016-08-08 13:50 GMT+09:00 Randy Dunlap <rdunlap@infradead.org>:
> 
>> --- a/net/sctp/transport.c
>> +++ b/net/sctp/transport.c
>> @@ -630,9 +630,7 @@ void sctp_transport_reset(struct sctp_transport *t)
>>         t->srtt = 0;
>>         t->rttvar = 0;
>>
>> -       /* Reset these additional varibles so that we have a clean
>> -        * slate.
>> -        */
>> +       /* Reset these additional variables so that we have a clean state. */
>>
>> * Nothing wrong with original comment.
> 
> 
> This hunk is doing three things:
> 
>  [1] varibles  -> variables
>  [2] slate   ->  state
>  [3] Make it into a single line
> 
> 
> Do you mean they are all unneeded changes?
> 

Sorry about that, I missed the varibles change. That change is correct.

The change of slate to state is not needed.

The single line change is OK also.

Thanks.


-- 
~Randy

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web