Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1457667 > unrolled thread

[PATCH] NTB: ntb_hw_intel: Fix typo in module parameter descriptions

Started byWei Yongjun <weiyj.lk@gmail.com>
First post2016-08-08 11:50 +0200
Last post2016-08-08 17:10 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] NTB: ntb_hw_intel: Fix typo in module parameter descriptions Wei Yongjun <weiyj.lk@gmail.com> - 2016-08-08 11:50 +0200
    RE: [PATCH] NTB: ntb_hw_intel: Fix typo in module parameter descriptions "Allen Hubbe" <Allen.Hubbe@emc.com> - 2016-08-08 15:10 +0200
      Re: [PATCH] NTB: ntb_hw_intel: Fix typo in module parameter descriptions Jon Mason <jdmason@kudzu.us> - 2016-08-08 17:10 +0200

#1457667 — [PATCH] NTB: ntb_hw_intel: Fix typo in module parameter descriptions

FromWei Yongjun <weiyj.lk@gmail.com>
Date2016-08-08 11:50 +0200
Subject[PATCH] NTB: ntb_hw_intel: Fix typo in module parameter descriptions
Message-ID<s3Pm1-85D-23@gated-at.bofh.it>
Fix typo in module parameter descriptions.

Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
 drivers/ntb/hw/intel/ntb_hw_intel.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.c b/drivers/ntb/hw/intel/ntb_hw_intel.c
index 0d5c29a..1ee61d9 100644
--- a/drivers/ntb/hw/intel/ntb_hw_intel.c
+++ b/drivers/ntb/hw/intel/ntb_hw_intel.c
@@ -112,17 +112,17 @@ MODULE_PARM_DESC(xeon_b2b_usd_bar2_addr64,
 
 module_param_named(xeon_b2b_usd_bar4_addr64,
 		   xeon_b2b_usd_addr.bar4_addr64, ullong, 0644);
-MODULE_PARM_DESC(xeon_b2b_usd_bar2_addr64,
+MODULE_PARM_DESC(xeon_b2b_usd_bar4_addr64,
 		 "XEON B2B USD BAR 4 64-bit address");
 
 module_param_named(xeon_b2b_usd_bar4_addr32,
 		   xeon_b2b_usd_addr.bar4_addr32, ullong, 0644);
-MODULE_PARM_DESC(xeon_b2b_usd_bar2_addr64,
+MODULE_PARM_DESC(xeon_b2b_usd_bar4_addr32,
 		 "XEON B2B USD split-BAR 4 32-bit address");
 
 module_param_named(xeon_b2b_usd_bar5_addr32,
 		   xeon_b2b_usd_addr.bar5_addr32, ullong, 0644);
-MODULE_PARM_DESC(xeon_b2b_usd_bar2_addr64,
+MODULE_PARM_DESC(xeon_b2b_usd_bar5_addr32,
 		 "XEON B2B USD split-BAR 5 32-bit address");
 
 module_param_named(xeon_b2b_dsd_bar2_addr64,
@@ -132,17 +132,17 @@ MODULE_PARM_DESC(xeon_b2b_dsd_bar2_addr64,
 
 module_param_named(xeon_b2b_dsd_bar4_addr64,
 		   xeon_b2b_dsd_addr.bar4_addr64, ullong, 0644);
-MODULE_PARM_DESC(xeon_b2b_dsd_bar2_addr64,
+MODULE_PARM_DESC(xeon_b2b_dsd_bar4_addr64,
 		 "XEON B2B DSD BAR 4 64-bit address");
 
 module_param_named(xeon_b2b_dsd_bar4_addr32,
 		   xeon_b2b_dsd_addr.bar4_addr32, ullong, 0644);
-MODULE_PARM_DESC(xeon_b2b_dsd_bar2_addr64,
+MODULE_PARM_DESC(xeon_b2b_dsd_bar4_addr32,
 		 "XEON B2B DSD split-BAR 4 32-bit address");
 
 module_param_named(xeon_b2b_dsd_bar5_addr32,
 		   xeon_b2b_dsd_addr.bar5_addr32, ullong, 0644);
-MODULE_PARM_DESC(xeon_b2b_dsd_bar2_addr64,
+MODULE_PARM_DESC(xeon_b2b_dsd_bar5_addr32,
 		 "XEON B2B DSD split-BAR 5 32-bit address");
 
 #ifndef ioread64

[toc] | [next] | [standalone]


#1457775

From"Allen Hubbe" <Allen.Hubbe@emc.com>
Date2016-08-08 15:10 +0200
Message-ID<s3StB-1Oa-39@gated-at.bofh.it>
In reply to#1457667
From: Wei Yongjun
> Fix typo in module parameter descriptions.
> 
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>

Acked-by: Allen Hubbe <Allen.Hubbe@emc.com>

> ---
>  drivers/ntb/hw/intel/ntb_hw_intel.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.c b/drivers/ntb/hw/intel/ntb_hw_intel.c
> index 0d5c29a..1ee61d9 100644
> --- a/drivers/ntb/hw/intel/ntb_hw_intel.c
> +++ b/drivers/ntb/hw/intel/ntb_hw_intel.c
> @@ -112,17 +112,17 @@ MODULE_PARM_DESC(xeon_b2b_usd_bar2_addr64,
> 
>  module_param_named(xeon_b2b_usd_bar4_addr64,
>  		   xeon_b2b_usd_addr.bar4_addr64, ullong, 0644);
> -MODULE_PARM_DESC(xeon_b2b_usd_bar2_addr64,
> +MODULE_PARM_DESC(xeon_b2b_usd_bar4_addr64,
>  		 "XEON B2B USD BAR 4 64-bit address");
> 
>  module_param_named(xeon_b2b_usd_bar4_addr32,
>  		   xeon_b2b_usd_addr.bar4_addr32, ullong, 0644);
> -MODULE_PARM_DESC(xeon_b2b_usd_bar2_addr64,
> +MODULE_PARM_DESC(xeon_b2b_usd_bar4_addr32,
>  		 "XEON B2B USD split-BAR 4 32-bit address");
> 
>  module_param_named(xeon_b2b_usd_bar5_addr32,
>  		   xeon_b2b_usd_addr.bar5_addr32, ullong, 0644);
> -MODULE_PARM_DESC(xeon_b2b_usd_bar2_addr64,
> +MODULE_PARM_DESC(xeon_b2b_usd_bar5_addr32,
>  		 "XEON B2B USD split-BAR 5 32-bit address");
> 
>  module_param_named(xeon_b2b_dsd_bar2_addr64,
> @@ -132,17 +132,17 @@ MODULE_PARM_DESC(xeon_b2b_dsd_bar2_addr64,
> 
>  module_param_named(xeon_b2b_dsd_bar4_addr64,
>  		   xeon_b2b_dsd_addr.bar4_addr64, ullong, 0644);
> -MODULE_PARM_DESC(xeon_b2b_dsd_bar2_addr64,
> +MODULE_PARM_DESC(xeon_b2b_dsd_bar4_addr64,
>  		 "XEON B2B DSD BAR 4 64-bit address");
> 
>  module_param_named(xeon_b2b_dsd_bar4_addr32,
>  		   xeon_b2b_dsd_addr.bar4_addr32, ullong, 0644);
> -MODULE_PARM_DESC(xeon_b2b_dsd_bar2_addr64,
> +MODULE_PARM_DESC(xeon_b2b_dsd_bar4_addr32,
>  		 "XEON B2B DSD split-BAR 4 32-bit address");
> 
>  module_param_named(xeon_b2b_dsd_bar5_addr32,
>  		   xeon_b2b_dsd_addr.bar5_addr32, ullong, 0644);
> -MODULE_PARM_DESC(xeon_b2b_dsd_bar2_addr64,
> +MODULE_PARM_DESC(xeon_b2b_dsd_bar5_addr32,
>  		 "XEON B2B DSD split-BAR 5 32-bit address");
> 
>  #ifndef ioread64

[toc] | [prev] | [next] | [standalone]


#1457857

FromJon Mason <jdmason@kudzu.us>
Date2016-08-08 17:10 +0200
Message-ID<s3UlH-2YB-7@gated-at.bofh.it>
In reply to#1457775
On Mon, Aug 8, 2016 at 9:08 AM, Allen Hubbe <Allen.Hubbe@emc.com> wrote:
> From: Wei Yongjun
>> Fix typo in module parameter descriptions.
>>
>> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
>
> Acked-by: Allen Hubbe <Allen.Hubbe@emc.com>

Another good catch.  Applied to the ntb branch.

Thanks,
Jon

>
>> ---
>>  drivers/ntb/hw/intel/ntb_hw_intel.c | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/ntb/hw/intel/ntb_hw_intel.c b/drivers/ntb/hw/intel/ntb_hw_intel.c
>> index 0d5c29a..1ee61d9 100644
>> --- a/drivers/ntb/hw/intel/ntb_hw_intel.c
>> +++ b/drivers/ntb/hw/intel/ntb_hw_intel.c
>> @@ -112,17 +112,17 @@ MODULE_PARM_DESC(xeon_b2b_usd_bar2_addr64,
>>
>>  module_param_named(xeon_b2b_usd_bar4_addr64,
>>                  xeon_b2b_usd_addr.bar4_addr64, ullong, 0644);
>> -MODULE_PARM_DESC(xeon_b2b_usd_bar2_addr64,
>> +MODULE_PARM_DESC(xeon_b2b_usd_bar4_addr64,
>>                "XEON B2B USD BAR 4 64-bit address");
>>
>>  module_param_named(xeon_b2b_usd_bar4_addr32,
>>                  xeon_b2b_usd_addr.bar4_addr32, ullong, 0644);
>> -MODULE_PARM_DESC(xeon_b2b_usd_bar2_addr64,
>> +MODULE_PARM_DESC(xeon_b2b_usd_bar4_addr32,
>>                "XEON B2B USD split-BAR 4 32-bit address");
>>
>>  module_param_named(xeon_b2b_usd_bar5_addr32,
>>                  xeon_b2b_usd_addr.bar5_addr32, ullong, 0644);
>> -MODULE_PARM_DESC(xeon_b2b_usd_bar2_addr64,
>> +MODULE_PARM_DESC(xeon_b2b_usd_bar5_addr32,
>>                "XEON B2B USD split-BAR 5 32-bit address");
>>
>>  module_param_named(xeon_b2b_dsd_bar2_addr64,
>> @@ -132,17 +132,17 @@ MODULE_PARM_DESC(xeon_b2b_dsd_bar2_addr64,
>>
>>  module_param_named(xeon_b2b_dsd_bar4_addr64,
>>                  xeon_b2b_dsd_addr.bar4_addr64, ullong, 0644);
>> -MODULE_PARM_DESC(xeon_b2b_dsd_bar2_addr64,
>> +MODULE_PARM_DESC(xeon_b2b_dsd_bar4_addr64,
>>                "XEON B2B DSD BAR 4 64-bit address");
>>
>>  module_param_named(xeon_b2b_dsd_bar4_addr32,
>>                  xeon_b2b_dsd_addr.bar4_addr32, ullong, 0644);
>> -MODULE_PARM_DESC(xeon_b2b_dsd_bar2_addr64,
>> +MODULE_PARM_DESC(xeon_b2b_dsd_bar4_addr32,
>>                "XEON B2B DSD split-BAR 4 32-bit address");
>>
>>  module_param_named(xeon_b2b_dsd_bar5_addr32,
>>                  xeon_b2b_dsd_addr.bar5_addr32, ullong, 0644);
>> -MODULE_PARM_DESC(xeon_b2b_dsd_bar2_addr64,
>> +MODULE_PARM_DESC(xeon_b2b_dsd_bar5_addr32,
>>                "XEON B2B DSD split-BAR 5 32-bit address");
>>
>>  #ifndef ioread64
>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web