Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1457735 > unrolled thread

Re: [PATCH RFC V1] mfd: da9063: Update author information to remove incorrect e-mail addresses

Started byLee Jones <lee.jones@linaro.org>
First post2016-08-08 13:30 +0200
Last post2016-08-08 14:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH RFC V1] mfd: da9063: Update author information to remove  incorrect e-mail addresses Lee Jones <lee.jones@linaro.org> - 2016-08-08 13:30 +0200
    RE: [PATCH RFC V1] mfd: da9063: Update author information to remove  incorrect e-mail addresses Steve Twiss <stwiss.opensource@diasemi.com> - 2016-08-08 14:20 +0200

#1457735 — Re: [PATCH RFC V1] mfd: da9063: Update author information to remove incorrect e-mail addresses

FromLee Jones <lee.jones@linaro.org>
Date2016-08-08 13:30 +0200
SubjectRe: [PATCH RFC V1] mfd: da9063: Update author information to remove incorrect e-mail addresses
Message-ID<s3QUP-Mj-53@gated-at.bofh.it>
On Mon, 11 Jul 2016, Steve Twiss wrote:

> From: Steve Twiss <stwiss.opensource@diasemi.com>
> 
> Remove incorrect e-mail addresses from the copyright header and
> MODULE_AUTHOR() macro. These e-mail addresses are no longer in use.
> 
> The author names have not been changed, only the e-mail address have been
> deleted from the source files.
> 
> Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
> 
> ---
> 
> Hi Lee, 
> 
> There have been an increasing number of queries made from external
> developers. These queries have been made to the author names written into
> the driver files. Unfortunately, there are several author entries in our
> source files with Dialog Semiconductor e-mail addresses that are no longer
> valid.
> 
> These new changes I am proposing will erase the e-mail addresses without
> affecting the author names.
> 
> I hope this is acceptable.

Hmm... I'm not sure how I feel about this.  The email address provides
us more then just contact information. I think the minimum format I
will accept is:

  Krystian Garbaciak, Dialog Semiconductors

... etc.

>  drivers/mfd/da9063-core.c            | 6 +++---
>  drivers/mfd/da9063-i2c.c             | 2 +-
>  drivers/mfd/da9063-irq.c             | 2 +-
>  include/linux/mfd/da9063/core.h      | 4 ++--
>  include/linux/mfd/da9063/pdata.h     | 4 ++--
>  include/linux/mfd/da9063/registers.h | 4 ++--
>  6 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/mfd/da9063-core.c b/drivers/mfd/da9063-core.c
> index af841c1..d011486 100644
> --- a/drivers/mfd/da9063-core.c
> +++ b/drivers/mfd/da9063-core.c
> @@ -4,8 +4,8 @@
>   * Copyright 2012 Dialog Semiconductors Ltd.
>   * Copyright 2013 Philipp Zabel, Pengutronix
>   *
> - * Author: Krystian Garbaciak <krystian.garbaciak@diasemi.com>,
> - *         Michal Hajduk <michal.hajduk@diasemi.com>
> + * Author: Krystian Garbaciak
> + * Author: Michal Hajduk
>   *
>   *  This program is free software; you can redistribute  it and/or modify it
>   *  under  the terms of  the GNU General  Public License as published by the
> @@ -242,5 +242,5 @@ void da9063_device_exit(struct da9063 *da9063)
>  }
>  
>  MODULE_DESCRIPTION("PMIC driver for Dialog DA9063");
> -MODULE_AUTHOR("Krystian Garbaciak <krystian.garbaciak@diasemi.com>, Michal Hajduk <michal.hajduk@diasemi.com>");
> +MODULE_AUTHOR("Krystian Garbaciak, Michal Hajduk");
>  MODULE_LICENSE("GPL");
> diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c
> index 7390108..54959be 100644
> --- a/drivers/mfd/da9063-i2c.c
> +++ b/drivers/mfd/da9063-i2c.c
> @@ -3,7 +3,7 @@
>   * Copyright 2012 Dialog Semiconductor Ltd.
>   * Copyright 2013 Philipp Zabel, Pengutronix
>   *
> - * Author: Krystian Garbaciak <krystian.garbaciak@diasemi.com>
> + * Author: Krystian Garbaciak
>   *
>   *  This program is free software; you can redistribute  it and/or modify it
>   *  under  the terms of  the GNU General  Public License as published by the
> diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c
> index 7e903fc..230c813 100644
> --- a/drivers/mfd/da9063-irq.c
> +++ b/drivers/mfd/da9063-irq.c
> @@ -3,7 +3,7 @@
>   * Copyright 2012 Dialog Semiconductor Ltd.
>   * Copyright 2013 Philipp Zabel, Pengutronix
>   *
> - * Author: Michal Hajduk <michal.hajduk@diasemi.com>
> + * Author: Michal Hajduk
>   *
>   *  This program is free software; you can redistribute  it and/or modify it
>   *  under  the terms of  the GNU General  Public License as published by the
> diff --git a/include/linux/mfd/da9063/core.h b/include/linux/mfd/da9063/core.h
> index 621af82..6cc9e6c 100644
> --- a/include/linux/mfd/da9063/core.h
> +++ b/include/linux/mfd/da9063/core.h
> @@ -3,8 +3,8 @@
>   *
>   * Copyright 2012 Dialog Semiconductor Ltd.
>   *
> - * Author: Michal Hajduk <michal.hajduk@diasemi.com>
> - *	   Krystian Garbaciak <krystian.garbaciak@diasemi.com>
> + * Author: Michal Hajduk
> + * Author: Krystian Garbaciak
>   *
>   *  This program is free software; you can redistribute  it and/or modify it
>   *  under  the terms of  the GNU General  Public License as published by the
> diff --git a/include/linux/mfd/da9063/pdata.h b/include/linux/mfd/da9063/pdata.h
> index 612383b..b4201de 100644
> --- a/include/linux/mfd/da9063/pdata.h
> +++ b/include/linux/mfd/da9063/pdata.h
> @@ -3,8 +3,8 @@
>   *
>   * Copyright 2012 Dialog Semiconductor Ltd.
>   *
> - * Author: Michal Hajduk <michal.hajduk@diasemi.com>
> - * Author: Krystian Garbaciak <krystian.garbaciak@diasemi.com>
> + * Author: Michal Hajduk
> + * Author: Krystian Garbaciak
>   *
>   *  This program is free software; you can redistribute  it and/or modify it
>   *  under  the terms of  the GNU General  Public License as published by the
> diff --git a/include/linux/mfd/da9063/registers.h b/include/linux/mfd/da9063/registers.h
> index 2e0ba6d..2c34286 100644
> --- a/include/linux/mfd/da9063/registers.h
> +++ b/include/linux/mfd/da9063/registers.h
> @@ -3,8 +3,8 @@
>   *
>   * Copyright 2012 Dialog Semiconductor Ltd.
>   *
> - * Author: Michal Hajduk <michal.hajduk@diasemi.com>
> - *	   Krystian Garbaciak <krystian.garbaciak@diasemi.com>
> + * Author: Michal Hajduk
> + * Author: Krystian Garbaciak
>   *
>   *  This program is free software; you can redistribute  it and/or modify it
>   *  under  the terms of  the GNU General  Public License as published by the

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [next] | [standalone]


#1457753

FromSteve Twiss <stwiss.opensource@diasemi.com>
Date2016-08-08 14:20 +0200
Message-ID<s3RHb-1ii-9@gated-at.bofh.it>
In reply to#1457735
On 8 August 2016 12:25, Lee Jones wrote:
> To: Steve Twiss
> Cc: LINUXKERNEL
> Subject: Re: [PATCH RFC V1] mfd: da9063: Update author information to remove incorrect e-mail addresses
>
> On Mon, 11 Jul 2016, Steve Twiss wrote:
> > From: Steve Twiss <stwiss.opensource@diasemi.com>

[...]

> > Hi Lee,
> >
> > [...]
> > Unfortunately, there are several author entries in our source files with
> > Dialog Semiconductor e-mail addresses that are no longer valid. These
> > new changes I am proposing will erase the e-mail addresses without
> > affecting the author names.
> > [...]
> 
> Hmm... I'm not sure how I feel about this.  The email address provides
> us more then just contact information. I think the minimum format I
> will accept is:
> 
>   Krystian Garbaciak, Dialog Semiconductors

Yes, agreed. I should not remove the company name.
I will resend PATCH V2 with those changes

Regards,
Steve.

> >  drivers/mfd/da9063-core.c            | 6 +++---
> >  drivers/mfd/da9063-i2c.c             | 2 +-
> >  drivers/mfd/da9063-irq.c             | 2 +-
> >  include/linux/mfd/da9063/core.h      | 4 ++--
> >  include/linux/mfd/da9063/pdata.h     | 4 ++--
> >  include/linux/mfd/da9063/registers.h | 4 ++--
> >  6 files changed, 11 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/mfd/da9063-core.c b/drivers/mfd/da9063-core.c
> > index af841c1..d011486 100644
> > --- a/drivers/mfd/da9063-core.c
> > +++ b/drivers/mfd/da9063-core.c
> > @@ -4,8 +4,8 @@
> >   * Copyright 2012 Dialog Semiconductors Ltd.
> >   * Copyright 2013 Philipp Zabel, Pengutronix
> >   *
> > - * Author: Krystian Garbaciak <krystian.garbaciak@diasemi.com>,
> > - *         Michal Hajduk <michal.hajduk@diasemi.com>
> > + * Author: Krystian Garbaciak
> > + * Author: Michal Hajduk
> >   *
> >   *  This program is free software; you can redistribute  it and/or modify it
> >   *  under  the terms of  the GNU General  Public License as published by
> the
> > @@ -242,5 +242,5 @@ void da9063_device_exit(struct da9063 *da9063)
> >  }
> >
> >  MODULE_DESCRIPTION("PMIC driver for Dialog DA9063");
> > -MODULE_AUTHOR("Krystian Garbaciak
> <krystian.garbaciak@diasemi.com>, Michal Hajduk
> <michal.hajduk@diasemi.com>");
> > +MODULE_AUTHOR("Krystian Garbaciak, Michal Hajduk");
> >  MODULE_LICENSE("GPL");
> > diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c
> > index 7390108..54959be 100644
> > --- a/drivers/mfd/da9063-i2c.c
> > +++ b/drivers/mfd/da9063-i2c.c
> > @@ -3,7 +3,7 @@
> >   * Copyright 2012 Dialog Semiconductor Ltd.
> >   * Copyright 2013 Philipp Zabel, Pengutronix
> >   *
> > - * Author: Krystian Garbaciak <krystian.garbaciak@diasemi.com>
> > + * Author: Krystian Garbaciak
> >   *
> >   *  This program is free software; you can redistribute  it and/or modify it
> >   *  under  the terms of  the GNU General  Public License as published by
> the
> > diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c
> > index 7e903fc..230c813 100644
> > --- a/drivers/mfd/da9063-irq.c
> > +++ b/drivers/mfd/da9063-irq.c
> > @@ -3,7 +3,7 @@
> >   * Copyright 2012 Dialog Semiconductor Ltd.
> >   * Copyright 2013 Philipp Zabel, Pengutronix
> >   *
> > - * Author: Michal Hajduk <michal.hajduk@diasemi.com>
> > + * Author: Michal Hajduk
> >   *
> >   *  This program is free software; you can redistribute  it and/or modify it
> >   *  under  the terms of  the GNU General  Public License as published by
> the
> > diff --git a/include/linux/mfd/da9063/core.h
> b/include/linux/mfd/da9063/core.h
> > index 621af82..6cc9e6c 100644
> > --- a/include/linux/mfd/da9063/core.h
> > +++ b/include/linux/mfd/da9063/core.h
> > @@ -3,8 +3,8 @@
> >   *
> >   * Copyright 2012 Dialog Semiconductor Ltd.
> >   *
> > - * Author: Michal Hajduk <michal.hajduk@diasemi.com>
> > - *	   Krystian Garbaciak <krystian.garbaciak@diasemi.com>
> > + * Author: Michal Hajduk
> > + * Author: Krystian Garbaciak
> >   *
> >   *  This program is free software; you can redistribute  it and/or modify it
> >   *  under  the terms of  the GNU General  Public License as published by
> the
> > diff --git a/include/linux/mfd/da9063/pdata.h
> b/include/linux/mfd/da9063/pdata.h
> > index 612383b..b4201de 100644
> > --- a/include/linux/mfd/da9063/pdata.h
> > +++ b/include/linux/mfd/da9063/pdata.h
> > @@ -3,8 +3,8 @@
> >   *
> >   * Copyright 2012 Dialog Semiconductor Ltd.
> >   *
> > - * Author: Michal Hajduk <michal.hajduk@diasemi.com>
> > - * Author: Krystian Garbaciak <krystian.garbaciak@diasemi.com>
> > + * Author: Michal Hajduk
> > + * Author: Krystian Garbaciak
> >   *
> >   *  This program is free software; you can redistribute  it and/or modify it
> >   *  under  the terms of  the GNU General  Public License as published by
> the
> > diff --git a/include/linux/mfd/da9063/registers.h
> b/include/linux/mfd/da9063/registers.h
> > index 2e0ba6d..2c34286 100644
> > --- a/include/linux/mfd/da9063/registers.h
> > +++ b/include/linux/mfd/da9063/registers.h
> > @@ -3,8 +3,8 @@
> >   *
> >   * Copyright 2012 Dialog Semiconductor Ltd.
> >   *
> > - * Author: Michal Hajduk <michal.hajduk@diasemi.com>
> > - *	   Krystian Garbaciak <krystian.garbaciak@diasemi.com>
> > + * Author: Michal Hajduk
> > + * Author: Krystian Garbaciak
> >   *
> >   *  This program is free software; you can redistribute  it and/or modify it
> >   *  under  the terms of  the GNU General  Public License as published by
> the
> 
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web