Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1457383 > unrolled thread

[PATCH] ACPICA: Remove unnecessary '\n' in the end of ACPI_INFO output

Started byAlexander Kuleshov <kuleshovmail@gmail.com>
First post2016-08-07 00:00 +0200
Last post2016-08-08 23:40 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] ACPICA: Remove unnecessary '\n' in the end of ACPI_INFO output Alexander Kuleshov <kuleshovmail@gmail.com> - 2016-08-07 00:00 +0200
    RE: [PATCH] ACPICA: Remove unnecessary '\n' in the end of ACPI_INFO  output "Zheng, Lv" <lv.zheng@intel.com> - 2016-08-08 03:00 +0200
      RE: [PATCH] ACPICA: Remove unnecessary '\n' in the end of ACPI_INFO  output "Moore, Robert" <robert.moore@intel.com> - 2016-08-08 23:40 +0200

#1457383 — [PATCH] ACPICA: Remove unnecessary '\n' in the end of ACPI_INFO output

FromAlexander Kuleshov <kuleshovmail@gmail.com>
Date2016-08-07 00:00 +0200
Subject[PATCH] ACPICA: Remove unnecessary '\n' in the end of ACPI_INFO output
Message-ID<s3hNn-2UZ-5@gated-at.bofh.it>
as the ACPI_INFO already prints `\n` in the end itself.

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
 drivers/acpi/acpica/tbxfload.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/acpica/tbxfload.c b/drivers/acpi/acpica/tbxfload.c
index ac71abc..e7119b7 100644
--- a/drivers/acpi/acpica/tbxfload.c
+++ b/drivers/acpi/acpica/tbxfload.c
@@ -240,7 +240,7 @@ acpi_status acpi_tb_load_namespace(void)
 	}
 
 	if (!tables_failed) {
-		ACPI_INFO(("%u ACPI AML tables successfully acquired and loaded\n", tables_loaded));
+		ACPI_INFO(("%u ACPI AML tables successfully acquired and loaded", tables_loaded));
 	} else {
 		ACPI_ERROR((AE_INFO,
 			    "%u table load failures, %u successful",
-- 
2.8.0.rc3.1353.gea9bdc0

[toc] | [next] | [standalone]

#1457506 — RE: [PATCH] ACPICA: Remove unnecessary '\n' in the end of ACPI_INFO output

From"Zheng, Lv" <lv.zheng@intel.com>
Date2016-08-08 03:00 +0200
SubjectRE: [PATCH] ACPICA: Remove unnecessary '\n' in the end of ACPI_INFO output
Message-ID<s3H58-2Bd-9@gated-at.bofh.it>
In reply to#1457383
> From: Alexander Kuleshov [mailto:kuleshovmail@gmail.com]
> Subject: [PATCH] ACPICA: Remove unnecessary '\n' in the end of
> ACPI_INFO output
> 
> as the ACPI_INFO already prints `\n` in the end itself.
[Lv Zheng] 
Looks good.
Acked-by: Lv Zheng <lv.zheng@intel.com>
However this patch should go through ACPICA upstream.

Thanks
-Lv

> 
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
>  drivers/acpi/acpica/tbxfload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/acpica/tbxfload.c b/drivers/acpi/acpica/tbxfload.c
> index ac71abc..e7119b7 100644
> --- a/drivers/acpi/acpica/tbxfload.c
> +++ b/drivers/acpi/acpica/tbxfload.c
> @@ -240,7 +240,7 @@ acpi_status acpi_tb_load_namespace(void)
>  	}
> 
>  	if (!tables_failed) {
> -		ACPI_INFO(("%u ACPI AML tables successfully acquired and
> loaded\n", tables_loaded));
> +		ACPI_INFO(("%u ACPI AML tables successfully acquired and
> loaded", tables_loaded));
>  	} else {
>  		ACPI_ERROR((AE_INFO,
>  			    "%u table load failures, %u successful",
> --
> 2.8.0.rc3.1353.gea9bdc0

[toc] | [prev] | [next] | [standalone]

#1458262 — RE: [PATCH] ACPICA: Remove unnecessary '\n' in the end of ACPI_INFO output

From"Moore, Robert" <robert.moore@intel.com>
Date2016-08-08 23:40 +0200
SubjectRE: [PATCH] ACPICA: Remove unnecessary '\n' in the end of ACPI_INFO output
Message-ID<s40r8-6NC-17@gated-at.bofh.it>
In reply to#1457506
I put that \n in there to break up the output from AcpiExec. This comes up every year or so, I think I'll give up -- without really seeing the harm in an extra \n.



> -----Original Message-----
> From: Zheng, Lv
> Sent: Sunday, August 7, 2016 5:56 PM
> To: Alexander Kuleshov <kuleshovmail@gmail.com>; Moore, Robert
> <robert.moore@intel.com>
> Cc: Wysocki, Rafael J <rafael.j.wysocki@intel.com>; Len Brown
> <lenb@kernel.org>; linux-acpi@vger.kernel.org; devel@acpica.org; linux-
> kernel@vger.kernel.org
> Subject: RE: [PATCH] ACPICA: Remove unnecessary '\n' in the end of
> ACPI_INFO output
> 
> > From: Alexander Kuleshov [mailto:kuleshovmail@gmail.com]
> > Subject: [PATCH] ACPICA: Remove unnecessary '\n' in the end of
> > ACPI_INFO output
> >
> > as the ACPI_INFO already prints `\n` in the end itself.
> [Lv Zheng]
> Looks good.
> Acked-by: Lv Zheng <lv.zheng@intel.com>
> However this patch should go through ACPICA upstream.
> 
> Thanks
> -Lv
> 
> >
> > Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> > ---
> >  drivers/acpi/acpica/tbxfload.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/acpica/tbxfload.c
> > b/drivers/acpi/acpica/tbxfload.c index ac71abc..e7119b7 100644
> > --- a/drivers/acpi/acpica/tbxfload.c
> > +++ b/drivers/acpi/acpica/tbxfload.c
> > @@ -240,7 +240,7 @@ acpi_status acpi_tb_load_namespace(void)
> >  	}
> >
> >  	if (!tables_failed) {
> > -		ACPI_INFO(("%u ACPI AML tables successfully acquired and
> > loaded\n", tables_loaded));
> > +		ACPI_INFO(("%u ACPI AML tables successfully acquired and
> > loaded", tables_loaded));
> >  	} else {
> >  		ACPI_ERROR((AE_INFO,
> >  			    "%u table load failures, %u successful",
> > --
> > 2.8.0.rc3.1353.gea9bdc0

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web