Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1456418 > unrolled thread
| Started by | Nicolas Ferre <nicolas.ferre@atmel.com> |
|---|---|
| First post | 2016-08-04 16:10 +0200 |
| Last post | 2016-08-05 06:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [RFC PATCH 1/2] net: macb: Correct CAPS mask Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-08-04 16:10 +0200
Re: [RFC PATCH 1/2] net: macb: Correct CAPS mask Harini Katakam <harinikatakamlinux@gmail.com> - 2016-08-05 06:20 +0200
| From | Nicolas Ferre <nicolas.ferre@atmel.com> |
|---|---|
| Date | 2016-08-04 16:10 +0200 |
| Subject | Re: [RFC PATCH 1/2] net: macb: Correct CAPS mask |
| Message-ID | <s2rvs-1NC-21@gated-at.bofh.it> |
Le 01/08/2016 à 09:20, Harini Katakam a écrit :
> USRIO and JUMBO CAPS have the same mask.
> Fix the same.
>
> Signed-off-by: Harini Katakam <harinik@xilinx.com>
Hi,
Indeed there's a bug...
> ---
> drivers/net/ethernet/cadence/macb.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h
> index 36893d8..b6fcf10 100644
> --- a/drivers/net/ethernet/cadence/macb.h
> +++ b/drivers/net/ethernet/cadence/macb.h
> @@ -403,11 +403,11 @@
> #define MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII 0x00000004
> #define MACB_CAPS_NO_GIGABIT_HALF 0x00000008
> #define MACB_CAPS_USRIO_DISABLED 0x00000010
> +#define MACB_CAPS_JUMBO 0x00000020
> #define MACB_CAPS_FIFO_MODE 0x10000000
> #define MACB_CAPS_GIGABIT_MODE_AVAILABLE 0x20000000
> #define MACB_CAPS_SG_DISABLED 0x40000000
> #define MACB_CAPS_MACB_IS_GEM 0x80000000
> -#define MACB_CAPS_JUMBO 0x00000010
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Can you please send it independently without the RFC tag in the subject
and with the following tags in the body as well:
Fixes: ce721a702197 ("net: ethernet: cadence-macb: Add disabled usrio caps")
Cc: stable@vger.kernel.org # v4.5+
> /* Bit manipulation macros */
> #define MACB_BIT(name) \
>
Thanks, bye,
--
Nicolas Ferre
[toc] | [next] | [standalone]
| From | Harini Katakam <harinikatakamlinux@gmail.com> |
|---|---|
| Date | 2016-08-05 06:20 +0200 |
| Message-ID | <s2EM2-2By-5@gated-at.bofh.it> |
| In reply to | #1456418 |
On Thu, Aug 4, 2016 at 7:37 PM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> Le 01/08/2016 à 09:20, Harini Katakam a écrit :
>> USRIO and JUMBO CAPS have the same mask.
>> Fix the same.
>>
>> Signed-off-by: Harini Katakam <harinik@xilinx.com>
>
> Hi,
> Indeed there's a bug...
>
>
>> ---
>> drivers/net/ethernet/cadence/macb.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h
>> index 36893d8..b6fcf10 100644
>> --- a/drivers/net/ethernet/cadence/macb.h
>> +++ b/drivers/net/ethernet/cadence/macb.h
>> @@ -403,11 +403,11 @@
>> #define MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII 0x00000004
>> #define MACB_CAPS_NO_GIGABIT_HALF 0x00000008
>> #define MACB_CAPS_USRIO_DISABLED 0x00000010
>> +#define MACB_CAPS_JUMBO 0x00000020
>> #define MACB_CAPS_FIFO_MODE 0x10000000
>> #define MACB_CAPS_GIGABIT_MODE_AVAILABLE 0x20000000
>> #define MACB_CAPS_SG_DISABLED 0x40000000
>> #define MACB_CAPS_MACB_IS_GEM 0x80000000
>> -#define MACB_CAPS_JUMBO 0x00000010
>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>
> Can you please send it independently without the RFC tag in the subject
> and with the following tags in the body as well:
>
> Fixes: ce721a702197 ("net: ethernet: cadence-macb: Add disabled usrio caps")
> Cc: stable@vger.kernel.org # v4.5+
>
Thanks Nicolas. I'll do that.
Regards,
Harini
>> /* Bit manipulation macros */
>> #define MACB_BIT(name) \
>>
>
> Thanks, bye,
> --
> Nicolas Ferre
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web