Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1456175 > unrolled thread
| Started by | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| First post | 2016-08-04 07:30 +0200 |
| Last post | 2016-08-09 15:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[patch] mfd: 88pm80x: Double shifting bug in suspend/resume Dan Carpenter <dan.carpenter@oracle.com> - 2016-08-04 07:30 +0200
Re: [patch] mfd: 88pm80x: Double shifting bug in suspend/resume Lee Jones <lee.jones@linaro.org> - 2016-08-09 15:50 +0200
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2016-08-04 07:30 +0200 |
| Subject | [patch] mfd: 88pm80x: Double shifting bug in suspend/resume |
| Message-ID | <s2joe-4Ab-11@gated-at.bofh.it> |
set_bit() and clear_bit() take the bit number so this code is really
doing "1 << (1 << irq)" which is a double shift bug. It's done
consistently so it won't cause a problem unless "irq" is more than 4.
Fixes: 70c6cce04066 ('mfd: Support 88pm80x in 80x driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/include/linux/mfd/88pm80x.h b/include/linux/mfd/88pm80x.h
index d409ceb..c118a7e 100644
--- a/include/linux/mfd/88pm80x.h
+++ b/include/linux/mfd/88pm80x.h
@@ -350,7 +350,7 @@ static inline int pm80x_dev_suspend(struct device *dev)
int irq = platform_get_irq(pdev, 0);
if (device_may_wakeup(dev))
- set_bit((1 << irq), &chip->wu_flag);
+ set_bit(irq, &chip->wu_flag);
return 0;
}
@@ -362,7 +362,7 @@ static inline int pm80x_dev_resume(struct device *dev)
int irq = platform_get_irq(pdev, 0);
if (device_may_wakeup(dev))
- clear_bit((1 << irq), &chip->wu_flag);
+ clear_bit(irq, &chip->wu_flag);
return 0;
}
[toc] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2016-08-09 15:50 +0200 |
| Message-ID | <s4fzP-8eY-29@gated-at.bofh.it> |
| In reply to | #1456175 |
On Thu, 04 Aug 2016, Dan Carpenter wrote:
> set_bit() and clear_bit() take the bit number so this code is really
> doing "1 << (1 << irq)" which is a double shift bug. It's done
> consistently so it won't cause a problem unless "irq" is more than 4.
>
> Fixes: 70c6cce04066 ('mfd: Support 88pm80x in 80x driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
> diff --git a/include/linux/mfd/88pm80x.h b/include/linux/mfd/88pm80x.h
> index d409ceb..c118a7e 100644
> --- a/include/linux/mfd/88pm80x.h
> +++ b/include/linux/mfd/88pm80x.h
> @@ -350,7 +350,7 @@ static inline int pm80x_dev_suspend(struct device *dev)
> int irq = platform_get_irq(pdev, 0);
>
> if (device_may_wakeup(dev))
> - set_bit((1 << irq), &chip->wu_flag);
> + set_bit(irq, &chip->wu_flag);
>
> return 0;
> }
> @@ -362,7 +362,7 @@ static inline int pm80x_dev_resume(struct device *dev)
> int irq = platform_get_irq(pdev, 0);
>
> if (device_may_wakeup(dev))
> - clear_bit((1 << irq), &chip->wu_flag);
> + clear_bit(irq, &chip->wu_flag);
>
> return 0;
> }
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web