Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1456925 > unrolled thread

Re: mfd: dm355evm_msp: Refactoring for add_child()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: mfd: dm355evm_msp: Refactoring for add_child() Lee Jones <lee.jones@linaro.org> - 2016-08-05 10:00 +0200
    Re: mfd: dm355evm_msp: Refactoring for add_child() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-05 21:00 +0200
      Re: mfd: dm355evm_msp: Refactoring for add_child() Lee Jones <lee.jones@linaro.org> - 2016-08-08 11:20 +0200
        Re: mfd: dm355evm_msp: Refactoring for add_child() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-08-08 11:40 +0200
          Re: mfd: dm355evm_msp: Refactoring for add_child() Lee Jones <lee.jones@linaro.org> - 2016-08-09 11:50 +0200

#1456925 — Re: mfd: dm355evm_msp: Refactoring for add_child()

On Fri, 01 Jul 2016, SF Markus Elfring wrote:

> > FYI, code looks fine.
> 
> Thanks for your acknowledgement.
> 
> 
> > ... but please take this opportunity to set-up your submission
> > environment i.e. using `git format-patch` and `git send-email`.
> 
> 
> Would you like to see any special settings to be mentioned
> in a section like "15) Explicit In-Reply-To headers" from
> the document "SubmittingPatches"?
> 
> 
> 
> > you've done that, please re-submit this patch with my:
> 
> Does the association of this patch with a bit relevant discussion
> really hinder the desired commit?

I'm unsure if you're not re-submitting because you're waiting for an
answer for me or not.  If you are, here it is.  And, don't do that. :)

Please submit your patch-set *not* connected to this, now very
tangled web of submissions, complete with all the Acks you've
accrued.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [next] | [standalone]

#1457250

> I'm unsure if you're not re-submitting because you're waiting for an
> answer for me or not.

I found your five commits (on 2016-06-29) for this patch series
sufficient in principle.
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=d313cdde71ec9a5c327a515c37a0dca2cca00de5


> If you are, here it is.  And, don't do that. :)

I find this feedback a bit strange.


> Please submit your patch-set *not* connected to this, now very
> tangled web of submissions, complete with all the Acks you've
> accrued.

I would find it nice if another one of my update suggestions
could be integrated after a bit of feedback evolved for a special
source code search pattern.

https://patchwork.kernel.org/patch/9199519/
https://patchwork.kernel.org/patch/9208925/
https://patchwork.kernel.org/patch/9210291/

It seems to be harder to achieve acceptance similar to the others.

Regards,
Markus

[toc] | [prev] | [next] | [standalone]

#1457638

On Fri, 05 Aug 2016, SF Markus Elfring wrote:

> > I'm unsure if you're not re-submitting because you're waiting for an
> > answer for me or not.
> 
> I found your five commits (on 2016-06-29) for this patch series
> sufficient in principle.
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=d313cdde71ec9a5c327a515c37a0dca2cca00de5
> 
> 
> > If you are, here it is.  And, don't do that. :)
> 
> I find this feedback a bit strange.
> 
> 
> > Please submit your patch-set *not* connected to this, now very
> > tangled web of submissions, complete with all the Acks you've
> > accrued.
> 
> I would find it nice if another one of my update suggestions
> could be integrated after a bit of feedback evolved for a special
> source code search pattern.
> 
> https://patchwork.kernel.org/patch/9199519/
> https://patchwork.kernel.org/patch/9208925/
> https://patchwork.kernel.org/patch/9210291/
> 
> It seems to be harder to achieve acceptance similar to the others.

I'm not entirely sure what you're trying to say.

Please rebase all of your unaccepted patches on v4.8-rc1.  Apply any
Acks that you've collected along the way and re-submit the set.

Please ensure, when you re-submit, you do so using `git format-patch`
and `git send-email`.  Also ensure you do not send them attached to
any other patch that you've previously sent.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [next] | [standalone]

#1457657

> Please rebase all of your unaccepted patches on v4.8-rc1.

Thanks for your suggestion. - Would you like to add any comments
to my remaining update suggestions for Linux modules
(besides "dm355evm_msp")?

I would like to clarify still a few implementation details then.
https://patchwork.kernel.org/patch/9210291/


> Also ensure you do not send them attached to any other patch
> that you've previously sent.

I imagine that another patch can evolve as a reply to a constructive
software development discussion, can't it?

Regards,
Markus

[toc] | [prev] | [next] | [standalone]

#1458551

On Mon, 08 Aug 2016, SF Markus Elfring wrote:

> > Please rebase all of your unaccepted patches on v4.8-rc1.
> 
> Thanks for your suggestion. - Would you like to add any comments
> to my remaining update suggestions for Linux modules
> (besides "dm355evm_msp")?
> 
> I would like to clarify still a few implementation details then.
> https://patchwork.kernel.org/patch/9210291/
> 
> 
> > Also ensure you do not send them attached to any other patch
> > that you've previously sent.
> 
> I imagine that another patch can evolve as a reply to a constructive
> software development discussion, can't it?

Yes, just don't send it attached (threaded -- using reply-to).

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web