Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1455888 > unrolled thread

[GIT PULL] fix overlayfs deadlock in file_remove_privs()

Back to article view | Back to linux.kernel

Contents

  [GIT PULL] fix overlayfs deadlock in file_remove_privs() Miklos Szeredi <miklos@szeredi.hu> - 2016-08-03 18:40 +0200
    Re: [GIT PULL] fix overlayfs deadlock in file_remove_privs() Al Viro <viro@ZenIV.linux.org.uk> - 2016-08-03 19:40 +0200

#1455888 — [GIT PULL] fix overlayfs deadlock in file_remove_privs()

Hi Al,

Please pull from:

  git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git for-viro

This fixes the deadlock introduced by making the suid removal actually work on
overlayfs.

Responsible commit 07a2daab49c5 ("ovl: Copy up underlying inode's ->i_mode to
overlay inode") unfortunately slipped through my testing and 4.7 was released
with this bug.

Two more patches are cleaning away unneeded exports of related helpers.

Thanks,
Miklos

---
Miklos Szeredi (3):
      vfs: fix deadlock in file_remove_privs() on overlayfs
      vfs: remove file_needs_remove_privs()
      vfs: make dentry_needs_remove_privs() internal

---
 fs/inode.c         | 7 +++----
 fs/internal.h      | 1 +
 include/linux/fs.h | 5 -----
 3 files changed, 4 insertions(+), 9 deletions(-)

[toc] | [next] | [standalone]

#1455914

On Wed, Aug 03, 2016 at 06:30:29PM +0200, Miklos Szeredi wrote:
> Hi Al,
> 
> Please pull from:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git for-viro
> 
> This fixes the deadlock introduced by making the suid removal actually work on
> overlayfs.
> 
> Responsible commit 07a2daab49c5 ("ovl: Copy up underlying inode's ->i_mode to
> overlay inode") unfortunately slipped through my testing and 4.7 was released
> with this bug.
> 
> Two more patches are cleaning away unneeded exports of related helpers.

Pulled, will push tonight.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web