Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1452888 > unrolled thread
| Started by | Salah Triki <salah.triki@gmail.com> |
|---|---|
| First post | 2016-07-31 22:40 +0200 |
| Last post | 2016-08-01 16:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 5/6] fs: befs: remove in vain variable assignment Salah Triki <salah.triki@gmail.com> - 2016-07-31 22:40 +0200
Re: [PATCH 5/6] fs: befs: remove in vain variable assignment Luis de Bethencourt <luisbg@osg.samsung.com> - 2016-08-01 16:20 +0200
| From | Salah Triki <salah.triki@gmail.com> |
|---|---|
| Date | 2016-07-31 22:40 +0200 |
| Subject | [PATCH 5/6] fs: befs: remove in vain variable assignment |
| Message-ID | <s15GF-4Uk-15@gated-at.bofh.it> |
There is no need to init res, since it will be overwitten later by befs_fblock2brun(). Signed-off-by: Salah Triki <salah.triki@gmail.com> --- fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 6bc5b40..2b68c81 100644 --- a/fs/befs/linuxvfs.c +++ b/fs/befs/linuxvfs.c @@ -120,7 +120,7 @@ befs_get_block(struct inode *inode, sector_t block, struct super_block *sb = inode->i_sb; befs_data_stream *ds = &BEFS_I(inode)->i_data.ds; befs_block_run run = BAD_IADDR; - int res = 0; + int res; ulong disk_off; befs_debug(sb, "---> befs_get_block() for inode %lu, block %ld", -- 1.9.1
[toc] | [next] | [standalone]
| From | Luis de Bethencourt <luisbg@osg.samsung.com> |
|---|---|
| Date | 2016-08-01 16:20 +0200 |
| Message-ID | <s1met-7pd-9@gated-at.bofh.it> |
| In reply to | #1452888 |
On 31/07/16 21:34, Salah Triki wrote: > There is no need to init res, since it will be overwitten later by > befs_fblock2brun(). > > Signed-off-by: Salah Triki <salah.triki@gmail.com> > --- > fs/befs/linuxvfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c > index 6bc5b40..2b68c81 100644 > --- a/fs/befs/linuxvfs.c > +++ b/fs/befs/linuxvfs.c > @@ -120,7 +120,7 @@ befs_get_block(struct inode *inode, sector_t block, > struct super_block *sb = inode->i_sb; > befs_data_stream *ds = &BEFS_I(inode)->i_data.ds; > befs_block_run run = BAD_IADDR; > - int res = 0; > + int res; > ulong disk_off; > > befs_debug(sb, "---> befs_get_block() for inode %lu, block %ld", > Looks good. Thanks Salah, Luis Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com> Pushed to the befs-next branch: https://github.com/luisbg/linux-befs/tree/befs-next
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web