Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1453158 > unrolled thread
| Started by | Juergen Gross <jgross@suse.com> |
|---|---|
| First post | 2016-08-01 13:50 +0200 |
| Last post | 2016-08-01 16:20 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] xen: Make VPMU init message look less scary Juergen Gross <jgross@suse.com> - 2016-08-01 13:50 +0200
Re: [Xen-devel] [PATCH] xen: Make VPMU init message look less scary Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> - 2016-08-01 16:20 +0200
Re: [Xen-devel] [PATCH] xen: Make VPMU init message look less scary Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-08-01 18:00 +0200
Re: [Xen-devel] [PATCH] xen: Make VPMU init message look less scary Juergen Gross <jgross@suse.com> - 2016-08-01 19:10 +0200
Re: [PATCH] xen: Make VPMU init message look less scary Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-08-01 16:20 +0200
| From | Juergen Gross <jgross@suse.com> |
|---|---|
| Date | 2016-08-01 13:50 +0200 |
| Subject | [PATCH] xen: Make VPMU init message look less scary |
| Message-ID | <s1jTk-5Ms-27@gated-at.bofh.it> |
The default for the Xen hypervisor is to not enable VPMU in order to
avoid security issues. In this case the Linux kernel will issue the
message "Could not initialize VPMU for cpu 0, error -95" which looks
more like an error than a normal state.
Change the message to something less scary in case the hypervisor
returns EOPNOTSUPP when trying to activate VPMU.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
arch/x86/xen/pmu.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
index 32bdc2c..e9d66fa 100644
--- a/arch/x86/xen/pmu.c
+++ b/arch/x86/xen/pmu.c
@@ -547,8 +547,11 @@ void xen_pmu_init(int cpu)
return;
fail:
- pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
- cpu, err);
+ if (err == -EOPNOTSUPP)
+ pr_info_once("VPMU usage disabled due to Xen settings\n");
+ else
+ pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
+ cpu, err);
free_pages((unsigned long)xenpmu_data, 0);
}
--
2.6.6
[toc] | [next] | [standalone]
| From | Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> |
|---|---|
| Date | 2016-08-01 16:20 +0200 |
| Subject | Re: [Xen-devel] [PATCH] xen: Make VPMU init message look less scary |
| Message-ID | <s1met-7pd-15@gated-at.bofh.it> |
| In reply to | #1453158 |
On Mon, Aug 01, 2016 at 01:41:20PM +0200, Juergen Gross wrote:
> The default for the Xen hypervisor is to not enable VPMU in order to
> avoid security issues. In this case the Linux kernel will issue the
> message "Could not initialize VPMU for cpu 0, error -95" which looks
> more like an error than a normal state.
>
> Change the message to something less scary in case the hypervisor
> returns EOPNOTSUPP when trying to activate VPMU.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> arch/x86/xen/pmu.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
> index 32bdc2c..e9d66fa 100644
> --- a/arch/x86/xen/pmu.c
> +++ b/arch/x86/xen/pmu.c
> @@ -547,8 +547,11 @@ void xen_pmu_init(int cpu)
> return;
>
> fail:
> - pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
> - cpu, err);
> + if (err == -EOPNOTSUPP)
> + pr_info_once("VPMU usage disabled due to Xen settings\n");
How about 'VPMU disabled by hypevisor.'
> + else
> + pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
> + cpu, err);
> free_pages((unsigned long)xenpmu_data, 0);
> }
>
> --
> 2.6.6
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
[toc] | [prev] | [next] | [standalone]
| From | Boris Ostrovsky <boris.ostrovsky@oracle.com> |
|---|---|
| Date | 2016-08-01 18:00 +0200 |
| Subject | Re: [Xen-devel] [PATCH] xen: Make VPMU init message look less scary |
| Message-ID | <s1nNf-8fZ-9@gated-at.bofh.it> |
| In reply to | #1453233 |
On 08/01/2016 11:48 AM, Juergen Gross wrote:
> On 01/08/16 16:11, Konrad Rzeszutek Wilk wrote:
>> On Mon, Aug 01, 2016 at 01:41:20PM +0200, Juergen Gross wrote:
>>> The default for the Xen hypervisor is to not enable VPMU in order to
>>> avoid security issues. In this case the Linux kernel will issue the
>>> message "Could not initialize VPMU for cpu 0, error -95" which looks
>>> more like an error than a normal state.
>>>
>>> Change the message to something less scary in case the hypervisor
>>> returns EOPNOTSUPP when trying to activate VPMU.
>>>
>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>> ---
>>> arch/x86/xen/pmu.c | 7 +++++--
>>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
>>> index 32bdc2c..e9d66fa 100644
>>> --- a/arch/x86/xen/pmu.c
>>> +++ b/arch/x86/xen/pmu.c
>>> @@ -547,8 +547,11 @@ void xen_pmu_init(int cpu)
>>> return;
>>>
>>> fail:
>>> - pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
>>> - cpu, err);
>>> + if (err == -EOPNOTSUPP)
>>> + pr_info_once("VPMU usage disabled due to Xen settings\n");
>> How about 'VPMU disabled by hypevisor.'
> Hmm, why not. Boris, are you okay with this message, too?
Sure.
[toc] | [prev] | [next] | [standalone]
| From | Juergen Gross <jgross@suse.com> |
|---|---|
| Date | 2016-08-01 19:10 +0200 |
| Subject | Re: [Xen-devel] [PATCH] xen: Make VPMU init message look less scary |
| Message-ID | <s1nNf-8fZ-11@gated-at.bofh.it> |
| In reply to | #1453233 |
On 01/08/16 16:11, Konrad Rzeszutek Wilk wrote:
> On Mon, Aug 01, 2016 at 01:41:20PM +0200, Juergen Gross wrote:
>> The default for the Xen hypervisor is to not enable VPMU in order to
>> avoid security issues. In this case the Linux kernel will issue the
>> message "Could not initialize VPMU for cpu 0, error -95" which looks
>> more like an error than a normal state.
>>
>> Change the message to something less scary in case the hypervisor
>> returns EOPNOTSUPP when trying to activate VPMU.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>> arch/x86/xen/pmu.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
>> index 32bdc2c..e9d66fa 100644
>> --- a/arch/x86/xen/pmu.c
>> +++ b/arch/x86/xen/pmu.c
>> @@ -547,8 +547,11 @@ void xen_pmu_init(int cpu)
>> return;
>>
>> fail:
>> - pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
>> - cpu, err);
>> + if (err == -EOPNOTSUPP)
>> + pr_info_once("VPMU usage disabled due to Xen settings\n");
>
> How about 'VPMU disabled by hypevisor.'
Hmm, why not. Boris, are you okay with this message, too?
Juergen
[toc] | [prev] | [next] | [standalone]
| From | Boris Ostrovsky <boris.ostrovsky@oracle.com> |
|---|---|
| Date | 2016-08-01 16:20 +0200 |
| Message-ID | <s1met-7pd-17@gated-at.bofh.it> |
| In reply to | #1453158 |
On 08/01/2016 07:41 AM, Juergen Gross wrote: > The default for the Xen hypervisor is to not enable VPMU in order to > avoid security issues. In this case the Linux kernel will issue the > message "Could not initialize VPMU for cpu 0, error -95" which looks > more like an error than a normal state. > > Change the message to something less scary in case the hypervisor > returns EOPNOTSUPP when trying to activate VPMU. > > Signed-off-by: Juergen Gross <jgross@suse.com> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web