Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1453153 > unrolled thread

[PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c

Started byJuergen Gross <jgross@suse.com>
First post2016-08-01 13:50 +0200
Last post2016-08-01 19:10 +0200
Articles 5 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c Juergen Gross <jgross@suse.com> - 2016-08-01 13:50 +0200
    Re: [PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-08-01 16:20 +0200
      Re: [PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c Juergen Gross <jgross@suse.com> - 2016-08-01 17:50 +0200
        Re: [PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-08-01 17:50 +0200
          Re: [PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c Juergen Gross <jgross@suse.com> - 2016-08-01 19:10 +0200

#1453153 — [PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c

FromJuergen Gross <jgross@suse.com>
Date2016-08-01 13:50 +0200
Subject[PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c
Message-ID<s1jTk-5Ms-17@gated-at.bofh.it>
There are two functions with name xen_pmu_init() in the kernel. Rename
the one in drivers/xen/sys-hypervisor.c to avoid shadowing the one in
arch/x86/xen/pmu.c

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 drivers/xen/sys-hypervisor.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c
index 6881b3c..17ea846 100644
--- a/drivers/xen/sys-hypervisor.c
+++ b/drivers/xen/sys-hypervisor.c
@@ -455,7 +455,7 @@ static const struct attribute_group xen_pmu_group = {
 	.attrs = xen_pmu_attrs,
 };
 
-static int __init xen_pmu_init(void)
+static int __init xen_sysfs_pmu_init(void)
 {
 	return sysfs_create_group(hypervisor_kobj, &xen_pmu_group);
 }
@@ -485,7 +485,7 @@ static int __init hyper_sysfs_init(void)
 		goto prop_out;
 #ifdef CONFIG_XEN_HAVE_VPMU
 	if (xen_initial_domain()) {
-		ret = xen_pmu_init();
+		ret = xen_sysfs_pmu_init();
 		if (ret) {
 			sysfs_remove_group(hypervisor_kobj,
 					   &xen_properties_group);
-- 
2.6.6

[toc] | [next] | [standalone]

#1453235

FromBoris Ostrovsky <boris.ostrovsky@oracle.com>
Date2016-08-01 16:20 +0200
Message-ID<s1met-7pd-13@gated-at.bofh.it>
In reply to#1453153
On 08/01/2016 07:40 AM, Juergen Gross wrote:
> There are two functions with name xen_pmu_init() in the kernel. Rename
> the one in drivers/xen/sys-hypervisor.c to avoid shadowing the one in
> arch/x86/xen/pmu.c
>
> Signed-off-by: Juergen Gross <jgross@suse.com>

While at it, how about changing xen_properties_init to
xen_sysfs_properties_init as well for consistency?

-boris

> ---
>  drivers/xen/sys-hypervisor.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c
> index 6881b3c..17ea846 100644
> --- a/drivers/xen/sys-hypervisor.c
> +++ b/drivers/xen/sys-hypervisor.c
> @@ -455,7 +455,7 @@ static const struct attribute_group xen_pmu_group = {
>  	.attrs = xen_pmu_attrs,
>  };
>  
> -static int __init xen_pmu_init(void)
> +static int __init xen_sysfs_pmu_init(void)
>  {
>  	return sysfs_create_group(hypervisor_kobj, &xen_pmu_group);
>  }
> @@ -485,7 +485,7 @@ static int __init hyper_sysfs_init(void)
>  		goto prop_out;
>  #ifdef CONFIG_XEN_HAVE_VPMU
>  	if (xen_initial_domain()) {
> -		ret = xen_pmu_init();
> +		ret = xen_sysfs_pmu_init();
>  		if (ret) {
>  			sysfs_remove_group(hypervisor_kobj,
>  					   &xen_properties_group);

[toc] | [prev] | [next] | [standalone]

#1453287

FromJuergen Gross <jgross@suse.com>
Date2016-08-01 17:50 +0200
Message-ID<s1nDA-8cv-15@gated-at.bofh.it>
In reply to#1453235
On 01/08/16 16:10, Boris Ostrovsky wrote:
> On 08/01/2016 07:40 AM, Juergen Gross wrote:
>> There are two functions with name xen_pmu_init() in the kernel. Rename
>> the one in drivers/xen/sys-hypervisor.c to avoid shadowing the one in
>> arch/x86/xen/pmu.c
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
> 
> While at it, how about changing xen_properties_init to
> xen_sysfs_properties_init as well for consistency?

I don't mind changing this name, too. Will send V2.


Juergen

[toc] | [prev] | [next] | [standalone]

#1453288

FromBoris Ostrovsky <boris.ostrovsky@oracle.com>
Date2016-08-01 17:50 +0200
Message-ID<s1nDA-8cv-17@gated-at.bofh.it>
In reply to#1453287
On 08/01/2016 11:44 AM, Juergen Gross wrote:
> On 01/08/16 16:10, Boris Ostrovsky wrote:
>> On 08/01/2016 07:40 AM, Juergen Gross wrote:
>>> There are two functions with name xen_pmu_init() in the kernel. Rename
>>> the one in drivers/xen/sys-hypervisor.c to avoid shadowing the one in
>>> arch/x86/xen/pmu.c
>>>
>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> While at it, how about changing xen_properties_init to
>> xen_sysfs_properties_init as well for consistency?
> I don't mind changing this name, too. Will send V2.

Thanks. Actually, there is one more --- xen_compilation_init().

-boris

[toc] | [prev] | [next] | [standalone]

#1453336

FromJuergen Gross <jgross@suse.com>
Date2016-08-01 19:10 +0200
Message-ID<s1oT1-Iy-45@gated-at.bofh.it>
In reply to#1453288
On 01/08/16 17:46, Boris Ostrovsky wrote:
> On 08/01/2016 11:44 AM, Juergen Gross wrote:
>> On 01/08/16 16:10, Boris Ostrovsky wrote:
>>> On 08/01/2016 07:40 AM, Juergen Gross wrote:
>>>> There are two functions with name xen_pmu_init() in the kernel. Rename
>>>> the one in drivers/xen/sys-hypervisor.c to avoid shadowing the one in
>>>> arch/x86/xen/pmu.c
>>>>
>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>> While at it, how about changing xen_properties_init to
>>> xen_sysfs_properties_init as well for consistency?
>> I don't mind changing this name, too. Will send V2.
> 
> Thanks. Actually, there is one more --- xen_compilation_init().

I'll do all of them.


Juergen

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web