Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1452949 > unrolled thread

[PATCH] silence warnings when building kernel/bpf/core.c with W=1

Back to article view | Back to linux.kernel

Contents

  [PATCH] silence warnings when building kernel/bpf/core.c with W=1 Valdis Kletnieks <Valdis.Kletnieks@vt.edu> - 2016-08-01 05:30 +0200
    Re: [PATCH] silence warnings when building kernel/bpf/core.c with  W=1 David Miller <davem@davemloft.net> - 2016-08-01 05:40 +0200

#1452949 — [PATCH] silence warnings when building kernel/bpf/core.c with W=1

Building with W=1 generates some 350 lines of warnings of the form:

kernel/bpf/core.c: In function '__bpf_prog_run':
kernel/bpf/core.c:476:33: warning: initialized field overwritten [-Woverride-init]
   [BPF_ALU | BPF_ADD | BPF_X] = &&ALU_ADD_X,
                                 ^~
kernel/bpf/core.c:476:33: note: (near initialization for 'jumptable[12]')

Since they come from the way we intentionally build the table, silence
that one specific warning.

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>

diff --git a/kernel/bpf/Makefile b/kernel/bpf/Makefile
index eed911d091da..bb915f9d9f92 100644
--- a/kernel/bpf/Makefile
+++ b/kernel/bpf/Makefile
@@ -1,3 +1,4 @@
+CFLAGS_core.o += -Wno-override-init
 obj-y := core.o
 
 obj-$(CONFIG_BPF_SYSCALL) += syscall.o verifier.o inode.o helpers.o

[toc] | [next] | [standalone]

#1452957 — Re: [PATCH] silence warnings when building kernel/bpf/core.c with W=1

From: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
Date: Sun, 31 Jul 2016 23:27:33 -0400

> Building with W=1 generates some 350 lines of warnings of the form:
> 
> kernel/bpf/core.c: In function '__bpf_prog_run':
> kernel/bpf/core.c:476:33: warning: initialized field overwritten [-Woverride-init]
>    [BPF_ALU | BPF_ADD | BPF_X] = &&ALU_ADD_X,
>                                  ^~
> kernel/bpf/core.c:476:33: note: (near initialization for 'jumptable[12]')
> 
> Since they come from the way we intentionally build the table, silence
> that one specific warning.
> 
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>

Patch submission must use a proper subsystem prefix in their Subject lines,
as this ends up in the kernel commit shortlog.

The appropriate subsystem prefix for this patch is "bpf: "

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web