Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1455249 > unrolled thread

[PATCH 0249/1285] Replace numeric parameter like 0444 with macro

Back to article view | Back to linux.kernel

Contents

  [PATCH 0249/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 20:10 +0200

#1455249 — [PATCH 0249/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/ide/ide-sysfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ide/ide-sysfs.c b/drivers/ide/ide-sysfs.c
index 84a6a9e..a210338a 100644
--- a/drivers/ide/ide-sysfs.c
+++ b/drivers/ide/ide-sysfs.c
@@ -65,9 +65,9 @@ static ssize_t serial_show(struct device *dev, struct device_attribute *attr,
 	ide_drive_t *drive = to_ide_device(dev);
 	return sprintf(buf, "%s\n", (char *)&drive->id[ATA_ID_SERNO]);
 }
-static DEVICE_ATTR(serial, 0400, serial_show, NULL);
+static DEVICE_ATTR(serial, S_IRUSR, serial_show, NULL);
 
-static DEVICE_ATTR(unload_heads, 0644, ide_park_show, ide_park_store);
+static DEVICE_ATTR(unload_heads, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, ide_park_show, ide_park_store);
 
 static struct attribute *ide_attrs[] = {
 	&dev_attr_media.attr,
-- 
2.9.2

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web