Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1455168 > unrolled thread

[PATCH 0336/1285] Replace numeric parameter like 0444 with macro

Back to article view | Back to linux.kernel

Contents

  [PATCH 0336/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 19:40 +0200

#1455168 — [PATCH 0336/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/media/dvb-frontends/cx24116.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/media/dvb-frontends/cx24116.c b/drivers/media/dvb-frontends/cx24116.c
index 8814f36..bceb355 100644
--- a/drivers/media/dvb-frontends/cx24116.c
+++ b/drivers/media/dvb-frontends/cx24116.c
@@ -45,7 +45,7 @@
 #include "cx24116.h"
 
 static int debug;
-module_param(debug, int, 0644);
+module_param(debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(debug, "Activates frontend debugging (default:0)");
 
 #define dprintk(args...) \
@@ -130,13 +130,13 @@ MODULE_PARM_DESC(debug, "Activates frontend debugging (default:0)");
 
 /* DiSEqC tone burst */
 static int toneburst = 1;
-module_param(toneburst, int, 0644);
+module_param(toneburst, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(toneburst, "DiSEqC toneburst 0=OFF, 1=TONE CACHE, "\
 	"2=MESSAGE CACHE (default:1)");
 
 /* SNR measurements */
 static int esno_snr;
-module_param(esno_snr, int, 0644);
+module_param(esno_snr, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(esno_snr, "SNR return units, 0=PERCENTAGE 0-100, "\
 	"1=ESNO(db * 10) (default:0)");
 
-- 
2.9.2

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web