Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1454168 > unrolled thread

[PATCH 0947/1285] Replace numeric parameter like 0444 with macro

Back to article view | Back to linux.kernel

Contents

  [PATCH 0947/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 14:50 +0200
    Re: [PATCH 0947/1285] Replace numeric parameter like 0444 with  macro Mauro Carvalho Chehab <maurochehab@gmail.com> - 2016-08-02 16:40 +0200
      Re: [PATCH 0947/1285] Replace numeric parameter like 0444 with macro Randy Dunlap <rdunlap@infradead.org> - 2016-08-02 17:50 +0200
      Re: [PATCH 0947/1285] Replace numeric parameter like 0444 with macro Steve Cotton <steve@s.cotton.clara.co.uk> - 2016-08-02 22:20 +0200

#1454168 — [PATCH 0947/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/staging/media/omap1/omap1_camera.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/omap1/omap1_camera.c b/drivers/staging/media/omap1/omap1_camera.c
index 54b8dd2..6e125dc 100644
--- a/drivers/staging/media/omap1/omap1_camera.c
+++ b/drivers/staging/media/omap1/omap1_camera.c
@@ -1692,7 +1692,7 @@ static struct platform_driver omap1_cam_driver = {
 
 module_platform_driver(omap1_cam_driver);
 
-module_param(sg_mode, bool, 0644);
+module_param(sg_mode, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(sg_mode, "videobuf mode, 0: dma-contig (default), 1: dma-sg");
 
 MODULE_DESCRIPTION("OMAP1 Camera Interface driver");
-- 
2.9.2

[toc] | [next] | [standalone]

#1454592 — Re: [PATCH 0947/1285] Replace numeric parameter like 0444 with macro

Em Tue,  2 Aug 2016 20:01:34 +0800
Baole Ni <baolex.ni@intel.com> escreveu:

> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.

Gah!

A patch series with 1285 patches with identical subject!

Please don't ever do something like that. My inbox is not trash!

Instead, please group the changes per subsystem, and use different
names for each patch. Makes easier for people to review.

also, you need to send the patches to the subsystem mainatiner, and
not adding a random list of people like this:

To: gregkh@linuxfoundation.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com

Btw, use *just* the more recent email of the maintainer, instead of
spamming trash to all our emails (even to the ones that we don't use
anymore!

I'll just send all those things to /dev/null until you fix your
email sending process.

Regards,
Mauro

> 
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
> ---
>  drivers/staging/media/omap1/omap1_camera.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/omap1/omap1_camera.c b/drivers/staging/media/omap1/omap1_camera.c
> index 54b8dd2..6e125dc 100644
> --- a/drivers/staging/media/omap1/omap1_camera.c
> +++ b/drivers/staging/media/omap1/omap1_camera.c
> @@ -1692,7 +1692,7 @@ static struct platform_driver omap1_cam_driver = {
>  
>  module_platform_driver(omap1_cam_driver);
>  
> -module_param(sg_mode, bool, 0644);
> +module_param(sg_mode, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
>  MODULE_PARM_DESC(sg_mode, "videobuf mode, 0: dma-contig (default), 1: dma-sg");
>  
>  MODULE_DESCRIPTION("OMAP1 Camera Interface driver");

[toc] | [prev] | [next] | [standalone]

#1454817

On 08/02/16 05:51, Mauro Carvalho Chehab wrote:
> Em Tue,  2 Aug 2016 20:01:34 +0800
> Baole Ni <baolex.ni@intel.com> escreveu:
> 
>> I find that the developers often just specified the numeric value
>> when calling a macro which is defined with a parameter for access permission.
>> As we know, these numeric value for access permission have had the corresponding macro,
>> and that using macro can improve the robustness and readability of the code,
>> thus, I suggest replacing the numeric parameter with the macro.
> 
> Gah!
> 
> A patch series with 1285 patches with identical subject!
> 
> Please don't ever do something like that. My inbox is not trash!
> 
> Instead, please group the changes per subsystem, and use different
> names for each patch. Makes easier for people to review.
> 
> also, you need to send the patches to the subsystem mainatiner, and
> not adding a random list of people like this:
> 
> To: gregkh@linuxfoundation.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com
> 
> Btw, use *just* the more recent email of the maintainer, instead of
> spamming trash to all our emails (even to the ones that we don't use
> anymore!
> 
> I'll just send all those things to /dev/null until you fix your
> email sending process.
>
+1285

There are people at Intel who know about things like this.

-- 
~Randy

[toc] | [prev] | [next] | [standalone]

#1455445

On Tue, Aug 02, 2016 at 09:51:18AM -0300, Mauro Carvalho Chehab wrote:
> Em Tue,  2 Aug 2016 20:01:34 +0800 Baole Ni <baolex.ni@intel.com> escreveu:
> 
> > I find that the developers often just specified the numeric value
> > when calling a macro which is defined with a parameter for access permission.
> > As we know, these numeric value for access permission have had the corresponding macro,
> > and that using macro can improve the robustness and readability of the code,
> > thus, I suggest replacing the numeric parameter with the macro.
> 
> Gah!
> 
> A patch series with 1285 patches with identical subject!
> 
> Please don't ever do something like that. My inbox is not trash!
> 
> Instead, please group the changes per subsystem, and use different
> names for each patch. Makes easier for people to review.

Hi Baole,

It may also be worth waiting for the first group to be reviewed before
sending the other groups, in case the review comments change what you
send later.

> > -module_param(sg_mode, bool, 0644);
> > +module_param(sg_mode, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);

There's an S_IRUGO macro which makes the above just 'S_IRUGO | S_IWUSR'.

Regards,
Steve

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web