Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1454170 > unrolled thread

[PATCH 0986/1285] Replace numeric parameter like 0444 with macro

Back to article view | Back to linux.kernel

Contents

  [PATCH 0986/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 14:50 +0200
    Re: [PATCH 0986/1285] Replace numeric parameter like 0444 with macro Felipe Balbi <balbi@kernel.org> - 2016-08-02 16:40 +0200

#1454170 — [PATCH 0986/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/usb/phy/phy-tahvo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c
index ab5d364..a297861 100644
--- a/drivers/usb/phy/phy-tahvo.c
+++ b/drivers/usb/phy/phy-tahvo.c
@@ -73,7 +73,7 @@ static ssize_t vbus_state_show(struct device *device,
 	struct tahvo_usb *tu = dev_get_drvdata(device);
 	return sprintf(buf, "%s\n", tu->vbus_state ? "on" : "off");
 }
-static DEVICE_ATTR(vbus, 0444, vbus_state_show, NULL);
+static DEVICE_ATTR(vbus, S_IRUSR | S_IRGRP | S_IROTH, vbus_state_show, NULL);
 
 static void check_vbus_state(struct tahvo_usb *tu)
 {
@@ -318,7 +318,7 @@ static ssize_t otg_mode_store(struct device *device,
 
 	return r;
 }
-static DEVICE_ATTR(otg_mode, 0644, otg_mode_show, otg_mode_store);
+static DEVICE_ATTR(otg_mode, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, otg_mode_show, otg_mode_store);
 
 static struct attribute *tahvo_attributes[] = {
 	&dev_attr_vbus.attr,
-- 
2.9.2

[toc] | [next] | [standalone]

#1454568

[Multipart message — attachments visible in raw view] — view raw

Baole Ni <baolex.ni@intel.com> writes:

> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
> ---
>  drivers/usb/phy/phy-tahvo.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c
> index ab5d364..a297861 100644
> --- a/drivers/usb/phy/phy-tahvo.c
> +++ b/drivers/usb/phy/phy-tahvo.c
> @@ -73,7 +73,7 @@ static ssize_t vbus_state_show(struct device *device,
>  	struct tahvo_usb *tu = dev_get_drvdata(device);
>  	return sprintf(buf, "%s\n", tu->vbus_state ? "on" : "off");
>  }
> -static DEVICE_ATTR(vbus, 0444, vbus_state_show, NULL);
> +static DEVICE_ATTR(vbus, S_IRUSR | S_IRGRP | S_IROTH, vbus_state_show, NULL);
>  
>  static void check_vbus_state(struct tahvo_usb *tu)
>  {
> @@ -318,7 +318,7 @@ static ssize_t otg_mode_store(struct device *device,
>  
>  	return r;
>  }
> -static DEVICE_ATTR(otg_mode, 0644, otg_mode_show, otg_mode_store);
> +static DEVICE_ATTR(otg_mode, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, otg_mode_show, otg_mode_store);

line too long

-- 
balbi

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web