Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1454550 > unrolled thread

[PATCH 1025/1285] Replace numeric parameter like 0444 with macro

Back to article view | Back to linux.kernel

Contents

  [PATCH 1025/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 16:30 +0200

#1454550 — [PATCH 1025/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/w1/masters/ds2482.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/w1/masters/ds2482.c b/drivers/w1/masters/ds2482.c
index 2e30db1..63b346f 100644
--- a/drivers/w1/masters/ds2482.c
+++ b/drivers/w1/masters/ds2482.c
@@ -34,7 +34,7 @@
  * only a single slave on the 1-Wire line.
  */
 static int ds2482_active_pullup = 1;
-module_param_named(active_pullup, ds2482_active_pullup, int, 0644);
+module_param_named(active_pullup, ds2482_active_pullup, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 
 /**
  * The DS2482 registers - there are 3 registers that are addressed by a read
-- 
2.9.2

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web