Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1454196 > unrolled thread

[PATCH 1045/1285] Replace numeric parameter like 0444 with macro

Back to article view | Back to linux.kernel

Contents

  [PATCH 1045/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 15:00 +0200
    Re: [PATCH 1045/1285] Replace numeric parameter like 0444 with macro Dave Kleikamp <dave.kleikamp@oracle.com> - 2016-08-02 22:50 +0200

#1454196 — [PATCH 1045/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 fs/jfs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/jfs/super.c b/fs/jfs/super.c
index cec8814..c348410 100644
--- a/fs/jfs/super.c
+++ b/fs/jfs/super.c
@@ -67,7 +67,7 @@ struct task_struct *jfsSyncThread;
 
 #ifdef CONFIG_JFS_DEBUG
 int jfsloglevel = JFS_LOGLEVEL_WARN;
-module_param(jfsloglevel, int, 0644);
+module_param(jfsloglevel, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(jfsloglevel, "Specify JFS loglevel (0, 1 or 2)");
 #endif
 
-- 
2.9.2

[toc] | [next] | [standalone]

#1455465

Trimming the cc list..

On 08/02/2016 07:11 AM, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.

NACK for the same reasons that others have rejected companion patches.

0644 is much easier to read than S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH.

> 
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
> ---
>  fs/jfs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/jfs/super.c b/fs/jfs/super.c
> index cec8814..c348410 100644
> --- a/fs/jfs/super.c
> +++ b/fs/jfs/super.c
> @@ -67,7 +67,7 @@ struct task_struct *jfsSyncThread;
>  
>  #ifdef CONFIG_JFS_DEBUG
>  int jfsloglevel = JFS_LOGLEVEL_WARN;
> -module_param(jfsloglevel, int, 0644);
> +module_param(jfsloglevel, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
>  MODULE_PARM_DESC(jfsloglevel, "Specify JFS loglevel (0, 1 or 2)");
>  #endif

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web