Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1454252 > unrolled thread
| Started by | Baole Ni <baolex.ni@intel.com> |
|---|---|
| First post | 2016-08-02 15:10 +0200 |
| Last post | 2016-08-02 15:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1169/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 15:10 +0200
Re: [PATCH 1169/1285] Replace numeric parameter like 0444 with macro Takashi Sakamoto <o-takashi@sakamocchi.jp> - 2016-08-02 15:40 +0200
| From | Baole Ni <baolex.ni@intel.com> |
|---|---|
| Date | 2016-08-02 15:10 +0200 |
| Subject | [PATCH 1169/1285] Replace numeric parameter like 0444 with macro |
| Message-ID | <s1HCi-4RK-35@gated-at.bofh.it> |
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com> Signed-off-by: Baole Ni <baolex.ni@intel.com> --- sound/firewire/bebob/bebob.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/firewire/bebob/bebob.c b/sound/firewire/bebob/bebob.c index f7e2cbd..ec67fc6 100644 --- a/sound/firewire/bebob/bebob.c +++ b/sound/firewire/bebob/bebob.c @@ -22,11 +22,11 @@ static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX; static char *id[SNDRV_CARDS] = SNDRV_DEFAULT_STR; static bool enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE_PNP; -module_param_array(index, int, NULL, 0444); +module_param_array(index, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(index, "card index"); -module_param_array(id, charp, NULL, 0444); +module_param_array(id, charp, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(id, "ID string"); -module_param_array(enable, bool, NULL, 0444); +module_param_array(enable, bool, NULL, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(enable, "enable BeBoB sound card"); static DEFINE_MUTEX(devices_mutex); -- 2.9.2
[toc] | [next] | [standalone]
| From | Takashi Sakamoto <o-takashi@sakamocchi.jp> |
|---|---|
| Date | 2016-08-02 15:40 +0200 |
| Message-ID | <s1I5k-54A-67@gated-at.bofh.it> |
| In reply to | #1454252 |
On Aug 2 2016 21:22, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com> > Signed-off-by: Baole Ni <baolex.ni@intel.com> Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> > --- > sound/firewire/bebob/bebob.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sound/firewire/bebob/bebob.c b/sound/firewire/bebob/bebob.c > index f7e2cbd..ec67fc6 100644 > --- a/sound/firewire/bebob/bebob.c > +++ b/sound/firewire/bebob/bebob.c > @@ -22,11 +22,11 @@ static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX; > static char *id[SNDRV_CARDS] = SNDRV_DEFAULT_STR; > static bool enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE_PNP; > > -module_param_array(index, int, NULL, 0444); > +module_param_array(index, int, NULL, S_IRUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(index, "card index"); > -module_param_array(id, charp, NULL, 0444); > +module_param_array(id, charp, NULL, S_IRUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(id, "ID string"); > -module_param_array(enable, bool, NULL, 0444); > +module_param_array(enable, bool, NULL, S_IRUSR | S_IRGRP | S_IROTH); > MODULE_PARM_DESC(enable, "enable BeBoB sound card"); > > static DEFINE_MUTEX(devices_mutex);
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web