Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1454240 > unrolled thread

Re: [PATCH] radix-tree: account nodes to memcg only if explicitly requested

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] radix-tree: account nodes to memcg only if explicitly  requested Michal Hocko <mhocko@kernel.org> - 2016-08-02 15:10 +0200
    Re: [PATCH] radix-tree: account nodes to memcg only if explicitly  requested Andrew Morton <akpm@linux-foundation.org> - 2016-08-02 21:00 +0200

#1454240 — Re: [PATCH] radix-tree: account nodes to memcg only if explicitly requested

On Tue 02-08-16 15:42:20, Vladimir Davydov wrote:
> On Tue, Aug 02, 2016 at 01:51:12PM +0200, Michal Hocko wrote:
> > On Mon 01-08-16 16:13:08, Vladimir Davydov wrote:
> > > Radix trees may be used not only for storing page cache pages, so
> > > unconditionally accounting radix tree nodes to the current memory cgroup
> > > is bad: if a radix tree node is used for storing data shared among
> > > different cgroups we risk pinning dead memory cgroups forever. So let's
> > > only account radix tree nodes if it was explicitly requested by passing
> > > __GFP_ACCOUNT to INIT_RADIX_TREE. Currently, we only want to account
> > > page cache entries, so mark mapping->page_tree so.
> > > 
> > > Signed-off-by: Vladimir Davydov <vdavydov@virtuozzo.com>
> > 
> > OK, the patch makes sense to me. Such a false sharing would be really
> > tedious to debug
> > 
> > Do we want to mark it for stable 4.6 to prevent from some pathological
> > issues. The patch is simple enough.
> 
> Makes sense, expecially taking into account that kmemcg is enabled by
> default now.
>
> I'll resend the patch for stable then.

Maybe Andrew just want's to mark it for stable with
Fixes: 58e698af4c63 ("radix-tree: account radix_tree_node to memory cgroup")
 Cc: stable # 4.6

> > Acked-by: Michal Hocko <mhocko@suse.com>
> 
> Thanks!
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

-- 
Michal Hocko
SUSE Labs

[toc] | [next] | [standalone]

#1455392

On Tue, 2 Aug 2016 14:46:45 +0200 Michal Hocko <mhocko@kernel.org> wrote:

> Maybe Andrew just want's to mark it for stable with
> Fixes: 58e698af4c63 ("radix-tree: account radix_tree_node to memory cgroup")
>  Cc: stable # 4.6

Done.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web