Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1453755 > unrolled thread
| Started by | Baole Ni <baolex.ni@intel.com> |
|---|---|
| First post | 2016-08-02 13:20 +0200 |
| Last post | 2016-08-02 13:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 0011/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 13:20 +0200
Re: [PATCH 0011/1285] Replace numeric parameter like 0444 with macro Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> - 2016-08-02 13:40 +0200
| From | Baole Ni <baolex.ni@intel.com> |
|---|---|
| Date | 2016-08-02 13:20 +0200 |
| Subject | [PATCH 0011/1285] Replace numeric parameter like 0444 with macro |
| Message-ID | <s1FTQ-3Ey-39@gated-at.bofh.it> |
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com> Signed-off-by: Baole Ni <baolex.ni@intel.com> --- arch/avr32/kernel/cpu.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/avr32/kernel/cpu.c b/arch/avr32/kernel/cpu.c index 0341ae2..c4c96af 100644 --- a/arch/avr32/kernel/cpu.c +++ b/arch/avr32/kernel/cpu.c @@ -171,12 +171,12 @@ static ssize_t store_pcenable(struct device *dev, return count; } -static DEVICE_ATTR(pc0event, 0600, show_pc0event, store_pc0event); -static DEVICE_ATTR(pc0count, 0600, show_pc0count, store_pc0count); -static DEVICE_ATTR(pc1event, 0600, show_pc1event, store_pc1event); -static DEVICE_ATTR(pc1count, 0600, show_pc1count, store_pc1count); -static DEVICE_ATTR(pccycles, 0600, show_pccycles, store_pccycles); -static DEVICE_ATTR(pcenable, 0600, show_pcenable, store_pcenable); +static DEVICE_ATTR(pc0event, S_IRUSR | S_IWUSR, show_pc0event, store_pc0event); +static DEVICE_ATTR(pc0count, S_IRUSR | S_IWUSR, show_pc0count, store_pc0count); +static DEVICE_ATTR(pc1event, S_IRUSR | S_IWUSR, show_pc1event, store_pc1event); +static DEVICE_ATTR(pc1count, S_IRUSR | S_IWUSR, show_pc1count, store_pc1count); +static DEVICE_ATTR(pccycles, S_IRUSR | S_IWUSR, show_pccycles, store_pccycles); +static DEVICE_ATTR(pcenable, S_IRUSR | S_IWUSR, show_pcenable, store_pcenable); #endif /* CONFIG_PERFORMANCE_COUNTERS */ -- 2.9.2
[toc] | [next] | [standalone]
| From | Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> |
|---|---|
| Date | 2016-08-02 13:40 +0200 |
| Message-ID | <s1Gde-3Oh-99@gated-at.bofh.it> |
| In reply to | #1453755 |
Around Tue 02 Aug 2016 18:34:07 +0800 or thereabout, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com> > Signed-off-by: Baole Ni <baolex.ni@intel.com> Fine by me. Acked-by: Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> > --- > arch/avr32/kernel/cpu.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/avr32/kernel/cpu.c b/arch/avr32/kernel/cpu.c > index 0341ae2..c4c96af 100644 > --- a/arch/avr32/kernel/cpu.c > +++ b/arch/avr32/kernel/cpu.c > @@ -171,12 +171,12 @@ static ssize_t store_pcenable(struct device *dev, > return count; > } > > -static DEVICE_ATTR(pc0event, 0600, show_pc0event, store_pc0event); > -static DEVICE_ATTR(pc0count, 0600, show_pc0count, store_pc0count); > -static DEVICE_ATTR(pc1event, 0600, show_pc1event, store_pc1event); > -static DEVICE_ATTR(pc1count, 0600, show_pc1count, store_pc1count); > -static DEVICE_ATTR(pccycles, 0600, show_pccycles, store_pccycles); > -static DEVICE_ATTR(pcenable, 0600, show_pcenable, store_pcenable); > +static DEVICE_ATTR(pc0event, S_IRUSR | S_IWUSR, show_pc0event, store_pc0event); > +static DEVICE_ATTR(pc0count, S_IRUSR | S_IWUSR, show_pc0count, store_pc0count); > +static DEVICE_ATTR(pc1event, S_IRUSR | S_IWUSR, show_pc1event, store_pc1event); > +static DEVICE_ATTR(pc1count, S_IRUSR | S_IWUSR, show_pc1count, store_pc1count); > +static DEVICE_ATTR(pccycles, S_IRUSR | S_IWUSR, show_pccycles, store_pccycles); > +static DEVICE_ATTR(pcenable, S_IRUSR | S_IWUSR, show_pcenable, store_pcenable); > > #endif /* CONFIG_PERFORMANCE_COUNTERS */ -- Best regards, Hans-Christian Noren Egtvedt
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web