Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1453865 > unrolled thread

[PATCH 0271/1285] Replace numeric parameter like 0444 with macro

Back to article view | Back to linux.kernel

Contents

  [PATCH 0271/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 13:40 +0200
    Re: [PATCH 0271/1285] Replace numeric parameter like 0444 with macro Sagi Grimberg <sagi@grimberg.me> - 2016-08-02 17:00 +0200

#1453865 — [PATCH 0271/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/infiniband/ulp/isert/ib_isert.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
index a990c04..e2d11ac 100644
--- a/drivers/infiniband/ulp/isert/ib_isert.c
+++ b/drivers/infiniband/ulp/isert/ib_isert.c
@@ -39,7 +39,7 @@
 				 ISERT_MAX_CONN)
 
 static int isert_debug_level;
-module_param_named(debug_level, isert_debug_level, int, 0644);
+module_param_named(debug_level, isert_debug_level, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(debug_level, "Enable debug tracing if > 0 (default:0)");
 
 static DEFINE_MUTEX(device_list_mutex);
-- 
2.9.2

[toc] | [next] | [standalone]

#1454665

Acked-by: Sagi Grimberg <sagi@grmberg.me>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web