Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1454032 > unrolled thread

[PATCH 0658/1285] Replace numeric parameter like 0444 with macro

Back to article view | Back to linux.kernel

Contents

  [PATCH 0658/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 14:20 +0200
    Re: [PATCH 0658/1285] Replace numeric parameter like 0444 with macro Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> - 2016-08-03 21:30 +0200

#1454032 — [PATCH 0658/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/media/usb/usbvision/usbvision-core.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/media/usb/usbvision/usbvision-core.c b/drivers/media/usb/usbvision/usbvision-core.c
index 1ea04e7..06c7194 100644
--- a/drivers/media/usb/usbvision/usbvision-core.c
+++ b/drivers/media/usb/usbvision/usbvision-core.c
@@ -46,25 +46,25 @@
 #include "usbvision.h"
 
 static unsigned int core_debug;
-module_param(core_debug, int, 0644);
+module_param(core_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(core_debug, "enable debug messages [core]");
 
 static int adjust_compression = 1;	/* Set the compression to be adaptive */
-module_param(adjust_compression, int, 0444);
+module_param(adjust_compression, int, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(adjust_compression, " Set the ADPCM compression for the device.  Default: 1 (On)");
 
 /* To help people with Black and White output with using s-video input.
  * Some cables and input device are wired differently. */
 static int switch_svideo_input;
-module_param(switch_svideo_input, int, 0444);
+module_param(switch_svideo_input, int, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(switch_svideo_input, " Set the S-Video input.  Some cables and input device are wired differently. Default: 0 (Off)");
 
 static unsigned int adjust_x_offset = -1;
-module_param(adjust_x_offset, int, 0644);
+module_param(adjust_x_offset, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(adjust_x_offset, "adjust X offset display [core]");
 
 static unsigned int adjust_y_offset = -1;
-module_param(adjust_y_offset, int, 0644);
+module_param(adjust_y_offset, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(adjust_y_offset, "adjust Y offset display [core]");
 
 
-- 
2.9.2

[toc] | [next] | [standalone]

#1455983

Hi

On Tue, Aug 2, 2016 at 1:34 PM, Baole Ni <baolex.ni@intel.com> wrote:
> thus, I suggest replacing the numeric parameter with the macro.

For what my opinion is worth it... I found more comprehensive the
octal values than the macros, but maybe it is because I am old and
dream in hexadecimal....

I do not know if there is a consensus about this, but if there is not
maybe we should have that discussion before sending a 1K patchset.

Regards

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web