Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1454017 > unrolled thread

[PATCH 0642/1285] Replace numeric parameter like 0444 with macro

Back to article view | Back to linux.kernel

Contents

  [PATCH 0642/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 14:20 +0200

#1454017 — [PATCH 0642/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/media/usb/pwc/pwc-if.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/media/usb/pwc/pwc-if.c b/drivers/media/usb/pwc/pwc-if.c
index 18aed5d..cf8326c 100644
--- a/drivers/media/usb/pwc/pwc-if.c
+++ b/drivers/media/usb/pwc/pwc-if.c
@@ -1164,10 +1164,10 @@ static void usb_pwc_disconnect(struct usb_interface *intf)
 static unsigned int leds_nargs;
 
 #ifdef CONFIG_USB_PWC_DEBUG
-module_param_named(trace, pwc_trace, int, 0644);
+module_param_named(trace, pwc_trace, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 #endif
-module_param(power_save, int, 0644);
-module_param_array(leds, int, &leds_nargs, 0444);
+module_param(power_save, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
+module_param_array(leds, int, &leds_nargs, S_IRUSR | S_IRGRP | S_IROTH);
 
 #ifdef CONFIG_USB_PWC_DEBUG
 MODULE_PARM_DESC(trace, "For debugging purposes");
-- 
2.9.2

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web