Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1453981 > unrolled thread
| Started by | Baole Ni <baolex.ni@intel.com> |
|---|---|
| First post | 2016-08-02 14:10 +0200 |
| Last post | 2016-08-02 14:10 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
[PATCH 0267/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 14:10 +0200
| From | Baole Ni <baolex.ni@intel.com> |
|---|---|
| Date | 2016-08-02 14:10 +0200 |
| Subject | [PATCH 0267/1285] Replace numeric parameter like 0444 with macro |
| Message-ID | <s1GGe-4fp-23@gated-at.bofh.it> |
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com> Signed-off-by: Baole Ni <baolex.ni@intel.com> --- drivers/infiniband/ulp/ipoib/ipoib_cm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/ulp/ipoib/ipoib_cm.c b/drivers/infiniband/ulp/ipoib/ipoib_cm.c index 951d9ab..8c74c58 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_cm.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_cm.c @@ -43,7 +43,7 @@ int ipoib_max_conn_qp = 128; -module_param_named(max_nonsrq_conn_qp, ipoib_max_conn_qp, int, 0444); +module_param_named(max_nonsrq_conn_qp, ipoib_max_conn_qp, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(max_nonsrq_conn_qp, "Max number of connected-mode QPs per interface " "(applied only if shared receive queue is not available)"); @@ -51,7 +51,7 @@ MODULE_PARM_DESC(max_nonsrq_conn_qp, #ifdef CONFIG_INFINIBAND_IPOIB_DEBUG_DATA static int data_debug_level; -module_param_named(cm_data_debug_level, data_debug_level, int, 0644); +module_param_named(cm_data_debug_level, data_debug_level, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(cm_data_debug_level, "Enable data path debug tracing for connected mode if > 0"); #endif -- 2.9.2
Back to top | Article view | linux.kernel
csiph-web