Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1452441 > unrolled thread
| Started by | Benjamin Tissoires <benjamin.tissoires@redhat.com> |
|---|---|
| First post | 2016-07-29 17:10 +0200 |
| Last post | 2016-08-01 02:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] ACPI / button: remove pointer to old lid_sysfs on unbind Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-07-29 17:10 +0200
RE: [PATCH v2] ACPI / button: remove pointer to old lid_sysfs on unbind "Zheng, Lv" <lv.zheng@intel.com> - 2016-08-01 02:40 +0200
| From | Benjamin Tissoires <benjamin.tissoires@redhat.com> |
|---|---|
| Date | 2016-07-29 17:10 +0200 |
| Subject | [PATCH v2] ACPI / button: remove pointer to old lid_sysfs on unbind |
| Message-ID | <s0hAe-6iI-21@gated-at.bofh.it> |
When we removed the procfs dir on error or if the driver is unbound, the two variables acpi_lid_dir and acpi_button_dir were not reset. On the next rebind, those static variables were not null and we couldn't re-register the device again. Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> -- changes in v2: - put the NULL assignments at their correct place --- drivers/acpi/button.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c index 5c3b091..a3873b3 100644 --- a/drivers/acpi/button.c +++ b/drivers/acpi/button.c @@ -191,8 +191,10 @@ remove_dev_dir: acpi_device_dir(device) = NULL; remove_lid_dir: remove_proc_entry(ACPI_BUTTON_SUBCLASS_LID, acpi_button_dir); + acpi_lid_dir = NULL; remove_button_dir: remove_proc_entry(ACPI_BUTTON_CLASS, acpi_root_dir); + acpi_button_dir = NULL; goto done; } @@ -209,7 +211,9 @@ static int acpi_button_remove_fs(struct acpi_device *device) acpi_lid_dir); acpi_device_dir(device) = NULL; remove_proc_entry(ACPI_BUTTON_SUBCLASS_LID, acpi_button_dir); + acpi_lid_dir = NULL; remove_proc_entry(ACPI_BUTTON_CLASS, acpi_root_dir); + acpi_button_dir = NULL; return 0; } -- 2.5.5
[toc] | [next] | [standalone]
| From | "Zheng, Lv" <lv.zheng@intel.com> |
|---|---|
| Date | 2016-08-01 02:40 +0200 |
| Subject | RE: [PATCH v2] ACPI / button: remove pointer to old lid_sysfs on unbind |
| Message-ID | <s19qV-7kW-5@gated-at.bofh.it> |
| In reply to | #1452441 |
Hi, Benjamin > From: Benjamin Tissoires [mailto:benjamin.tissoires@redhat.com] > Subject: [PATCH v2] ACPI / button: remove pointer to old lid_sysfs on > unbind > > When we removed the procfs dir on error or if the driver is > unbound, the two variables acpi_lid_dir and acpi_button_dir > were not reset. On the next rebind, those static variables > were not null and we couldn't re-register the device again. > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> [Lv Zheng] Looks good. Acked-by: Lv Zheng <lv.zheng@intel.com> Chhers Lv > > -- > changes in v2: > - put the NULL assignments at their correct place > --- > drivers/acpi/button.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c > index 5c3b091..a3873b3 100644 > --- a/drivers/acpi/button.c > +++ b/drivers/acpi/button.c > @@ -191,8 +191,10 @@ remove_dev_dir: > acpi_device_dir(device) = NULL; > remove_lid_dir: > remove_proc_entry(ACPI_BUTTON_SUBCLASS_LID, > acpi_button_dir); > + acpi_lid_dir = NULL; > remove_button_dir: > remove_proc_entry(ACPI_BUTTON_CLASS, acpi_root_dir); > + acpi_button_dir = NULL; > goto done; > } > > @@ -209,7 +211,9 @@ static int acpi_button_remove_fs(struct > acpi_device *device) > acpi_lid_dir); > acpi_device_dir(device) = NULL; > remove_proc_entry(ACPI_BUTTON_SUBCLASS_LID, > acpi_button_dir); > + acpi_lid_dir = NULL; > remove_proc_entry(ACPI_BUTTON_CLASS, acpi_root_dir); > + acpi_button_dir = NULL; > > return 0; > } > -- > 2.5.5
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web