Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1452513 > unrolled thread

[PATCH] block: remove BLK_DEV_DAX config option

Back to article view | Back to linux.kernel

Contents

  [PATCH] block: remove BLK_DEV_DAX config option Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-07-29 20:30 +0200
    Re: [PATCH] block: remove BLK_DEV_DAX config option Dan Williams <dan.j.williams@intel.com> - 2016-07-29 22:40 +0200
    Re: [PATCH] block: remove BLK_DEV_DAX config option Jens Axboe <axboe@kernel.dk> - 2016-07-29 23:20 +0200

#1452513 — [PATCH] block: remove BLK_DEV_DAX config option

The functionality for block device DAX was already removed with this
commit:

commit acc93d30d7d4 ("Revert "block: enable dax for raw block devices"")

However, we still had a config option hanging around that was always
disabled because it depended on CONFIG_BROKEN.  This config option was
introduced in this commit:

commit 03cdadb04077 ("block: disable block device DAX by default")

This change reverts that commit, removing the dead config option.

Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
---
 block/Kconfig  | 13 -------------
 fs/block_dev.c |  5 +----
 2 files changed, 1 insertion(+), 17 deletions(-)

diff --git a/block/Kconfig b/block/Kconfig
index 0363cd7..161491d 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -88,19 +88,6 @@ config BLK_DEV_INTEGRITY
 	T10/SCSI Data Integrity Field or the T13/ATA External Path
 	Protection.  If in doubt, say N.
 
-config BLK_DEV_DAX
-	bool "Block device DAX support"
-	depends on FS_DAX
-	depends on BROKEN
-	help
-	  When DAX support is available (CONFIG_FS_DAX) raw block
-	  devices can also support direct userspace access to the
-	  storage capacity via MMAP(2) similar to a file on a
-	  DAX-enabled filesystem.  However, the DAX I/O-path disables
-	  some standard I/O-statistics, and the MMAP(2) path has some
-	  operational differences due to bypassing the page
-	  cache.  If in doubt, say N.
-
 config BLK_DEV_THROTTLING
 	bool "Block layer bio throttling support"
 	depends on BLK_CGROUP=y
diff --git a/fs/block_dev.c b/fs/block_dev.c
index 71ccab1..ab7ebee 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -1287,10 +1287,7 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, int for_part)
 		bdev->bd_disk = disk;
 		bdev->bd_queue = disk->queue;
 		bdev->bd_contains = bdev;
-		if (IS_ENABLED(CONFIG_BLK_DEV_DAX) && disk->fops->direct_access)
-			bdev->bd_inode->i_flags = S_DAX;
-		else
-			bdev->bd_inode->i_flags = 0;
+		bdev->bd_inode->i_flags = 0;
 
 		if (!partno) {
 			ret = -ENXIO;
-- 
2.9.0

[toc] | [next] | [standalone]

#1452551

On Fri, Jul 29, 2016 at 11:23 AM, Ross Zwisler
<ross.zwisler@linux.intel.com> wrote:
> The functionality for block device DAX was already removed with this
> commit:
>
> commit acc93d30d7d4 ("Revert "block: enable dax for raw block devices"")
>
> However, we still had a config option hanging around that was always
> disabled because it depended on CONFIG_BROKEN.  This config option was
> introduced in this commit:
>
> commit 03cdadb04077 ("block: disable block device DAX by default")
>
> This change reverts that commit, removing the dead config option.
>
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>

Acked-by: Dan Williams <dan.j.williams@intel.com>

[toc] | [prev] | [next] | [standalone]

#1452573

On 07/29/2016 12:23 PM, Ross Zwisler wrote:
> The functionality for block device DAX was already removed with this
> commit:
>
> commit acc93d30d7d4 ("Revert "block: enable dax for raw block devices"")
>
> However, we still had a config option hanging around that was always
> disabled because it depended on CONFIG_BROKEN.  This config option was
> introduced in this commit:
>
> commit 03cdadb04077 ("block: disable block device DAX by default")
>
> This change reverts that commit, removing the dead config option.

This doesn't apply to master, nor for-linus. I hand applied it.

-- 
Jens Axboe

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web