Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1451795 > unrolled thread
| Started by | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| First post | 2016-07-28 10:30 +0200 |
| Last post | 2016-08-02 21:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] usb: dwc2: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-07-28 10:30 +0200
Re: [PATCH] usb: dwc2: Remove deprecated create_singlethread_workqueue Tejun Heo <tj@kernel.org> - 2016-07-29 15:20 +0200
Re: [PATCH] usb: dwc2: Remove deprecated create_singlethread_workqueue John Youn <John.Youn@synopsys.com> - 2016-08-02 21:40 +0200
| From | Bhaktipriya Shridhar <bhaktipriya96@gmail.com> |
|---|---|
| Date | 2016-07-28 10:30 +0200 |
| Subject | [PATCH] usb: dwc2: Remove deprecated create_singlethread_workqueue |
| Message-ID | <rZORz-3Ef-5@gated-at.bofh.it> |
alloc_ordered_workqueue replaces the deprecated
create_singlethread_workqueue.
There are multiple work items on the work queue, which require
ordering. Hence, an ordered workqueue has been used.
The workqueue "wq_otg" is not being used on a memory reclaim path.
Hence, WQ_MEM_RECLAIM has not been set.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/usb/dwc2/hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index 2df3d04..df5a065 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/dwc2/hcd.c
@@ -5040,7 +5040,7 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg, int irq)
/* Create new workqueue and init work */
retval = -ENOMEM;
- hsotg->wq_otg = create_singlethread_workqueue("dwc2");
+ hsotg->wq_otg = alloc_ordered_workqueue("dwc2", 0);
if (!hsotg->wq_otg) {
dev_err(hsotg->dev, "Failed to create workqueue\n");
goto error2;
--
2.1.4
[toc] | [next] | [standalone]
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Date | 2016-07-29 15:20 +0200 |
| Subject | Re: [PATCH] usb: dwc2: Remove deprecated create_singlethread_workqueue |
| Message-ID | <s0fRM-55X-9@gated-at.bofh.it> |
| In reply to | #1451795 |
On Thu, Jul 28, 2016 at 01:57:29PM +0530, Bhaktipriya Shridhar wrote: > alloc_ordered_workqueue replaces the deprecated > create_singlethread_workqueue. > > There are multiple work items on the work queue, which require > ordering. Hence, an ordered workqueue has been used. > > The workqueue "wq_otg" is not being used on a memory reclaim path. > Hence, WQ_MEM_RECLAIM has not been set. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Acked-by: Tejun Heo <tj@kernel.org> Thanks. -- tejun
[toc] | [prev] | [next] | [standalone]
| From | John Youn <John.Youn@synopsys.com> |
|---|---|
| Date | 2016-08-02 21:40 +0200 |
| Subject | Re: [PATCH] usb: dwc2: Remove deprecated create_singlethread_workqueue |
| Message-ID | <s1NHH-vc-3@gated-at.bofh.it> |
| In reply to | #1451795 |
++ Felipe
On 7/28/2016 1:27 AM, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue replaces the deprecated
> create_singlethread_workqueue.
>
> There are multiple work items on the work queue, which require
> ordering. Hence, an ordered workqueue has been used.
>
> The workqueue "wq_otg" is not being used on a memory reclaim path.
> Hence, WQ_MEM_RECLAIM has not been set.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
> drivers/usb/dwc2/hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
> index 2df3d04..df5a065 100644
> --- a/drivers/usb/dwc2/hcd.c
> +++ b/drivers/usb/dwc2/hcd.c
> @@ -5040,7 +5040,7 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg, int irq)
>
> /* Create new workqueue and init work */
> retval = -ENOMEM;
> - hsotg->wq_otg = create_singlethread_workqueue("dwc2");
> + hsotg->wq_otg = alloc_ordered_workqueue("dwc2", 0);
> if (!hsotg->wq_otg) {
> dev_err(hsotg->dev, "Failed to create workqueue\n");
> goto error2;
> --
> 2.1.4
>
>
Acked-by: John Youn <johnyoun@synopsys.com>
John
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web