Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1452812 > unrolled thread
| Started by | Heinrich Schuchardt <xypron.glpk@gmx.de> |
|---|---|
| First post | 2016-07-31 13:30 +0200 |
| Last post | 2016-08-01 22:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 1/1] qed: do not use unitialized variable Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-07-31 13:30 +0200
RE: [PATCH 1/1] qed: do not use unitialized variable Yuval Mintz <Yuval.Mintz@qlogic.com> - 2016-07-31 16:20 +0200
Re: [PATCH 1/1] qed: do not use unitialized variable David Miller <davem@davemloft.net> - 2016-08-01 22:50 +0200
| From | Heinrich Schuchardt <xypron.glpk@gmx.de> |
|---|---|
| Date | 2016-07-31 13:30 +0200 |
| Subject | [PATCH 1/1] qed: do not use unitialized variable |
| Message-ID | <s0X6p-7T8-5@gated-at.bofh.it> |
Do not write random bytes from the kernel stack when
calling qed_wr.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
drivers/net/ethernet/qlogic/qed/qed_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c b/drivers/net/ethernet/qlogic/qed/qed_dev.c
index b26fe26..151cbf9 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dev.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_dev.c
@@ -888,7 +888,7 @@ static int qed_hw_init_pf(struct qed_hwfn *p_hwfn,
if (hw_mode & (1 << MODE_MF_SI)) {
u8 pf_id = 0;
- u32 val;
+ u32 val = 0;
if (!qed_hw_init_first_eth(p_hwfn, p_ptt, &pf_id)) {
if (p_hwfn->rel_pf_id == pf_id) {
--
2.8.1
[toc] | [next] | [standalone]
| From | Yuval Mintz <Yuval.Mintz@qlogic.com> |
|---|---|
| Date | 2016-07-31 16:20 +0200 |
| Message-ID | <s0ZKV-1cv-5@gated-at.bofh.it> |
| In reply to | #1452812 |
> Do not write random bytes from the kernel stack when calling qed_wr. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Thanks. Acked-by: Yuval Mintz <Yuval.Mintz@qlogic.com>
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-08-01 22:50 +0200 |
| Message-ID | <s1sjU-2WL-15@gated-at.bofh.it> |
| In reply to | #1452812 |
From: Heinrich Schuchardt <xypron.glpk@gmx.de> Date: Sun, 31 Jul 2016 13:24:52 +0200 > Do not write random bytes from the kernel stack when > calling qed_wr. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web