Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1452792 > unrolled thread
| Started by | Heinrich Schuchardt <xypron.glpk@gmx.de> |
|---|---|
| First post | 2016-07-31 11:10 +0200 |
| Last post | 2016-08-01 22:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/1] net: bna: use correct type specifier (2) Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-07-31 11:10 +0200
Re: [PATCH 1/1] net: bna: use correct type specifier (2) David Miller <davem@davemloft.net> - 2016-08-01 22:50 +0200
| From | Heinrich Schuchardt <xypron.glpk@gmx.de> |
|---|---|
| Date | 2016-07-31 11:10 +0200 |
| Subject | [PATCH 1/1] net: bna: use correct type specifier (2) |
| Message-ID | <s0UUV-6y2-1@gated-at.bofh.it> |
add and val are read with sscanf(kern_buf, "%x:%x", &addr, &val); and used as arguments for bna_reg_offset_check and writel so they have to be unsigned. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/brocade/bna/bnad_debugfs.c b/drivers/net/ethernet/brocade/bna/bnad_debugfs.c index cfcb00c..05c1c1d 100644 --- a/drivers/net/ethernet/brocade/bna/bnad_debugfs.c +++ b/drivers/net/ethernet/brocade/bna/bnad_debugfs.c @@ -373,7 +373,8 @@ bnad_debugfs_write_regwr(struct file *file, const char __user *buf, struct bnad_debug_info *debug = file->private_data; struct bnad *bnad = (struct bnad *)debug->i_private; struct bfa_ioc *ioc = &bnad->bna.ioceth.ioc; - int addr, val, rc; + int rc; + u32 addr, val; void __iomem *reg_addr; unsigned long flags; void *kern_buf; -- 2.8.1
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-08-01 22:50 +0200 |
| Message-ID | <s1sjU-2WL-23@gated-at.bofh.it> |
| In reply to | #1452792 |
From: Heinrich Schuchardt <xypron.glpk@gmx.de> Date: Sun, 31 Jul 2016 11:01:20 +0200 > add and val are read with > sscanf(kern_buf, "%x:%x", &addr, &val); > and used as arguments for bna_reg_offset_check and writel > so they have to be unsigned. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web