Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1452784 > unrolled thread
| Started by | Heinrich Schuchardt <xypron.glpk@gmx.de> |
|---|---|
| First post | 2016-07-31 10:10 +0200 |
| Last post | 2016-08-01 23:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/1] net: ethernet: ax88796: avoid null pointer dereference Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-07-31 10:10 +0200
Re: [PATCH 1/1] net: ethernet: ax88796: avoid null pointer dereference David Miller <davem@davemloft.net> - 2016-08-01 23:00 +0200
| From | Heinrich Schuchardt <xypron.glpk@gmx.de> |
|---|---|
| Date | 2016-07-31 10:10 +0200 |
| Subject | [PATCH 1/1] net: ethernet: ax88796: avoid null pointer dereference |
| Message-ID | <s0TYS-5XL-1@gated-at.bofh.it> |
If platform_get_resource fails, mem2 is null. Do not dereference null. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- drivers/net/ethernet/8390/ax88796.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/8390/ax88796.c b/drivers/net/ethernet/8390/ax88796.c index 5698f53..39ca935 100644 --- a/drivers/net/ethernet/8390/ax88796.c +++ b/drivers/net/ethernet/8390/ax88796.c @@ -910,7 +910,8 @@ static int ax_probe(struct platform_device *pdev) iounmap(ax->map2); exit_mem2: - release_mem_region(mem2->start, mem2_size); + if (mem2) + release_mem_region(mem2->start, mem2_size); exit_mem1: iounmap(ei_local->mem); -- 2.8.1
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-08-01 23:00 +0200 |
| Subject | Re: [PATCH 1/1] net: ethernet: ax88796: avoid null pointer dereference |
| Message-ID | <s1stz-32g-13@gated-at.bofh.it> |
| In reply to | #1452784 |
From: Heinrich Schuchardt <xypron.glpk@gmx.de> Date: Sun, 31 Jul 2016 09:58:44 +0200 > If platform_get_resource fails, mem2 is null. > Do not dereference null. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web