Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1452725 > unrolled thread
| Started by | Nayeemahmed Badebade <itachi.opsrc@gmail.com> |
|---|---|
| First post | 2016-07-30 18:40 +0200 |
| Last post | 2016-08-02 19:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: comedi/drivers: Fixed sparse warnings Nayeemahmed Badebade <itachi.opsrc@gmail.com> - 2016-07-30 18:40 +0200
Re: [PATCH] staging: comedi/drivers: Fixed sparse warnings Ian Abbott <abbotti@mev.co.uk> - 2016-08-02 19:00 +0200
| From | Nayeemahmed Badebade <itachi.opsrc@gmail.com> |
|---|---|
| Date | 2016-07-30 18:40 +0200 |
| Subject | [PATCH] staging: comedi/drivers: Fixed sparse warnings |
| Message-ID | <s0FsR-4SM-25@gated-at.bofh.it> |
Fixed below sparse warnings in dt2811.c
warning: symbol 'dt2811_clk_dividers' was not declared. Should it be static?
warning: symbol 'dt2811_clk_multipliers' was not declared. Should it be static?
Signed-off-by: Nayeemahmed Badebade <itachi.opsrc@gmail.com>
---
drivers/staging/comedi/drivers/dt2811.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt2811.c b/drivers/staging/comedi/drivers/dt2811.c
index 904f6377..07f99c0 100644
--- a/drivers/staging/comedi/drivers/dt2811.c
+++ b/drivers/staging/comedi/drivers/dt2811.c
@@ -96,11 +96,11 @@
* 6 6 100 kHz 6 1000000
* 7 12 50 kHz 7 10000000
*/
-const unsigned int dt2811_clk_dividers[] = {
+static const unsigned int dt2811_clk_dividers[] = {
1, 10, 2, 3, 4, 5, 6, 12
};
-const unsigned int dt2811_clk_multipliers[] = {
+static const unsigned int dt2811_clk_multipliers[] = {
1, 10, 100, 1000, 10000, 100000, 1000000, 10000000
};
--
1.9.1
[toc] | [next] | [standalone]
| From | Ian Abbott <abbotti@mev.co.uk> |
|---|---|
| Date | 2016-08-02 19:00 +0200 |
| Message-ID | <s1LcY-77c-67@gated-at.bofh.it> |
| In reply to | #1452725 |
On 30/07/16 17:38, Nayeemahmed Badebade wrote:
> Fixed below sparse warnings in dt2811.c
> warning: symbol 'dt2811_clk_dividers' was not declared. Should it be static?
> warning: symbol 'dt2811_clk_multipliers' was not declared. Should it be static?
>
> Signed-off-by: Nayeemahmed Badebade <itachi.opsrc@gmail.com>
> ---
> drivers/staging/comedi/drivers/dt2811.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/dt2811.c b/drivers/staging/comedi/drivers/dt2811.c
> index 904f6377..07f99c0 100644
> --- a/drivers/staging/comedi/drivers/dt2811.c
> +++ b/drivers/staging/comedi/drivers/dt2811.c
> @@ -96,11 +96,11 @@
> * 6 6 100 kHz 6 1000000
> * 7 12 50 kHz 7 10000000
> */
> -const unsigned int dt2811_clk_dividers[] = {
> +static const unsigned int dt2811_clk_dividers[] = {
> 1, 10, 2, 3, 4, 5, 6, 12
> };
>
> -const unsigned int dt2811_clk_multipliers[] = {
> +static const unsigned int dt2811_clk_multipliers[] = {
> 1, 10, 100, 1000, 10000, 100000, 1000000, 10000000
> };
>
> --
> 1.9.1
>
Thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web