Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1452681 > unrolled thread

[PATCH 0/1] drivers: staging: android: Remove checkpatch.pl-TODO

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/1] drivers: staging: android: Remove checkpatch.pl-TODO Matthias Beyer <mail@beyermatthias.de> - 2016-07-30 15:20 +0200
    [PATCH 1/1] Remove checkpatch.pl cleanups todo Matthias Beyer <mail@beyermatthias.de> - 2016-07-30 15:20 +0200

#1452681 — [PATCH 0/1] drivers: staging: android: Remove checkpatch.pl-TODO

Hi Arve,
Hi Riley,

I just noticed that the drivers/staging/android driver has only 4
remaining checkpatch.pl warnings, two of them beeing
80-character-per-line warnings (the two lines are 81 characters
exactly).

The other warnings are:

    ./sw_sync.c:258: WARNING: memory barrier without comment
    ./uapi/ion.h:23: WARNING: do not add new typedefs

I'm not sure about the first one, though I could provide a patch for
the second one. The change would simply remove

    typedef int ion_user_handle_t;

and replace all occurences of `ion_user_handle_t` with `int`.

I'm not sure, though, whether such a patch would be welcome.

Either way, I propose to remove the TODO note on checkpatch cleanup
with the attached patch.


Matthias Beyer (1):
  Remove checkpatch.pl cleanups todo

 drivers/staging/android/TODO | 1 -
 1 file changed, 1 deletion(-)

-- 
2.9.1

[toc] | [next] | [standalone]

#1452682 — [PATCH 1/1] Remove checkpatch.pl cleanups todo

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
---
 drivers/staging/android/TODO | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO
index 64d8c87..4ce0ac6 100644
--- a/drivers/staging/android/TODO
+++ b/drivers/staging/android/TODO
@@ -1,5 +1,4 @@
 TODO:
-	- checkpatch.pl cleanups
 	- sparse fixes
 	- rename files to be not so "generic"
 	- add proper arch dependencies as needed
-- 
2.9.1

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web