Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1451970 > unrolled thread
| Started by | James Smart <james.smart@broadcom.com> |
|---|---|
| First post | 2016-07-28 17:00 +0200 |
| Last post | 2016-07-29 10:10 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] lpfc: Fix possible NULL pointer dereference James Smart <james.smart@broadcom.com> - 2016-07-28 17:00 +0200
Re: [PATCH] lpfc: Fix possible NULL pointer dereference "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-07-29 03:30 +0200
Re: [PATCH] lpfc: Fix possible NULL pointer dereference Johannes Thumshirn <jthumshirn@suse.de> - 2016-07-29 10:10 +0200
| From | James Smart <james.smart@broadcom.com> |
|---|---|
| Date | 2016-07-28 17:00 +0200 |
| Subject | Re: [PATCH] lpfc: Fix possible NULL pointer dereference |
| Message-ID | <rZUWZ-7Ed-11@gated-at.bofh.it> |
This patch is good. Thanks
-- james
Signed-off-by: James Smart <james.smart@broadcom.com>
On 6/15/2016 6:00 AM, Johannes Thumshirn wrote:
> Check for the existance of pciob->vport before accessing it.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> ---
> drivers/scsi/lpfc/lpfc_sli.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
> index 70edf21..134078f 100644
> --- a/drivers/scsi/lpfc/lpfc_sli.c
> +++ b/drivers/scsi/lpfc/lpfc_sli.c
> @@ -1329,15 +1329,10 @@ lpfc_sli_ringtxcmpl_put(struct lpfc_hba *phba, struct lpfc_sli_ring *pring,
> if ((unlikely(pring->ringno == LPFC_ELS_RING)) &&
> (piocb->iocb.ulpCommand != CMD_ABORT_XRI_CN) &&
> (piocb->iocb.ulpCommand != CMD_CLOSE_XRI_CN) &&
> - (!(piocb->vport->load_flag & FC_UNLOADING))) {
> - if (!piocb->vport)
> - BUG();
> - else
> - mod_timer(&piocb->vport->els_tmofunc,
> - jiffies +
> - msecs_to_jiffies(1000 * (phba->fc_ratov << 1)));
> - }
> -
> + piocb->vport && !(piocb->vport->load_flag & FC_UNLOADING))
> + mod_timer(&piocb->vport->els_tmofunc,
> + jiffies +
> + msecs_to_jiffies(1000 * (phba->fc_ratov << 1)));
>
> return 0;
> }
[toc] | [next] | [standalone]
| From | "Martin K. Petersen" <martin.petersen@oracle.com> |
|---|---|
| Date | 2016-07-29 03:30 +0200 |
| Message-ID | <s04MF-63R-9@gated-at.bofh.it> |
| In reply to | #1451970 |
>>>>> "James" == James Smart <james.smart@broadcom.com> writes: James> This patch is good. Johannes: You were going to tweak a few things and resubmit. Please do. -- Martin K. Petersen Oracle Linux Engineering
[toc] | [prev] | [next] | [standalone]
| From | Johannes Thumshirn <jthumshirn@suse.de> |
|---|---|
| Date | 2016-07-29 10:10 +0200 |
| Message-ID | <s0b1M-20c-31@gated-at.bofh.it> |
| In reply to | #1452202 |
On Thu, Jul 28, 2016 at 09:21:47PM -0400, Martin K . Petersen wrote: > >>>>> "James" == James Smart <james.smart@broadcom.com> writes: > > James> This patch is good. > > Johannes: You were going to tweak a few things and resubmit. Please do. Oh yes, sorry totally forgot about this one. My bad. -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web