Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1401581 > unrolled thread
| Started by | Mario Limonciello <mario_limonciello@dell.com> |
|---|---|
| First post | 2016-05-16 17:50 +0200 |
| Last post | 2016-05-16 19:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] dell_rbu: Don't fallback to userhelper when loading firmware Mario Limonciello <mario_limonciello@dell.com> - 2016-05-16 17:50 +0200
Re: [PATCH] dell_rbu: Don't fallback to userhelper when loading firmware Laura Abbott <labbott@redhat.com> - 2016-05-16 19:20 +0200
RE: [PATCH] dell_rbu: Don't fallback to userhelper when loading firmware <Mario_Limonciello@Dell.com> - 2016-05-16 19:50 +0200
| From | Mario Limonciello <mario_limonciello@dell.com> |
|---|---|
| Date | 2016-05-16 17:50 +0200 |
| Subject | [PATCH] dell_rbu: Don't fallback to userhelper when loading firmware |
| Message-ID | <rzsWm-oE-13@gated-at.bofh.it> |
dell_rbu previously would allow a userspace application to craft the
payload after dell_rbu was loaded and abuse the udev userspace API.
Instead require the payload to be crafted and placed in
/lib/firmware/dell_rbu ahead of time.
This adjusts dell_rbu to immediately load the firmware from
/lib/firmware/dell_rbu when "init" is passed into image_type using the
kernel helper.
---
drivers/firmware/dell_rbu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/dell_rbu.c b/drivers/firmware/dell_rbu.c
index d5f5b98..5ecf043 100644
--- a/drivers/firmware/dell_rbu.c
+++ b/drivers/firmware/dell_rbu.c
@@ -677,7 +677,7 @@ static ssize_t write_rbu_image_type(struct file *filp, struct kobject *kobj,
if (!rbu_data.entry_created) {
spin_unlock(&rbu_data.lock);
req_firm_rc = request_firmware_nowait(THIS_MODULE,
- FW_ACTION_NOHOTPLUG,
+ FW_ACTION_HOTPLUG,
"dell_rbu",
&rbu_device->dev,
GFP_KERNEL,
--
2.7.4
[toc] | [next] | [standalone]
| From | Laura Abbott <labbott@redhat.com> |
|---|---|
| Date | 2016-05-16 19:20 +0200 |
| Subject | Re: [PATCH] dell_rbu: Don't fallback to userhelper when loading firmware |
| Message-ID | <rzuls-1pQ-17@gated-at.bofh.it> |
| In reply to | #1401581 |
On 05/16/2016 08:41 AM, Mario Limonciello wrote:
> dell_rbu previously would allow a userspace application to craft the
> payload after dell_rbu was loaded and abuse the udev userspace API.
>
> Instead require the payload to be crafted and placed in
> /lib/firmware/dell_rbu ahead of time.
>
> This adjusts dell_rbu to immediately load the firmware from
> /lib/firmware/dell_rbu when "init" is passed into image_type using the
> kernel helper.
Looks like you missed the Signed-off-by line.
Can you also drop the Kconfig dependency on CONFIG_FW_LOADER_USER_HELPER?
Thanks,
Laura
> ---
> drivers/firmware/dell_rbu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/dell_rbu.c b/drivers/firmware/dell_rbu.c
> index d5f5b98..5ecf043 100644
> --- a/drivers/firmware/dell_rbu.c
> +++ b/drivers/firmware/dell_rbu.c
> @@ -677,7 +677,7 @@ static ssize_t write_rbu_image_type(struct file *filp, struct kobject *kobj,
> if (!rbu_data.entry_created) {
> spin_unlock(&rbu_data.lock);
> req_firm_rc = request_firmware_nowait(THIS_MODULE,
> - FW_ACTION_NOHOTPLUG,
> + FW_ACTION_HOTPLUG,
> "dell_rbu",
> &rbu_device->dev,
> GFP_KERNEL,
>
[toc] | [prev] | [next] | [standalone]
| From | <Mario_Limonciello@Dell.com> |
|---|---|
| Date | 2016-05-16 19:50 +0200 |
| Subject | RE: [PATCH] dell_rbu: Don't fallback to userhelper when loading firmware |
| Message-ID | <rzuOu-1B1-11@gated-at.bofh.it> |
| In reply to | #1401650 |
> -----Original Message-----
> From: Laura Abbott [mailto:labbott@redhat.com]
> Sent: Monday, May 16, 2016 12:12 PM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>;
> ming.lei@canonical.com
> Cc: LKML <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH] dell_rbu: Don't fallback to userhelper when loading
> firmware
>
> On 05/16/2016 08:41 AM, Mario Limonciello wrote:
> > dell_rbu previously would allow a userspace application to craft the
> > payload after dell_rbu was loaded and abuse the udev userspace API.
> >
> > Instead require the payload to be crafted and placed in
> > /lib/firmware/dell_rbu ahead of time.
> >
> > This adjusts dell_rbu to immediately load the firmware from
> > /lib/firmware/dell_rbu when "init" is passed into image_type using the
> > kernel helper.
>
> Looks like you missed the Signed-off-by line.
>
> Can you also drop the Kconfig dependency on
> CONFIG_FW_LOADER_USER_HELPER?
>
> Thanks,
> Laura
Sure thing.
>
> > ---
> > drivers/firmware/dell_rbu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/firmware/dell_rbu.c b/drivers/firmware/dell_rbu.c
> > index d5f5b98..5ecf043 100644
> > --- a/drivers/firmware/dell_rbu.c
> > +++ b/drivers/firmware/dell_rbu.c
> > @@ -677,7 +677,7 @@ static ssize_t write_rbu_image_type(struct file *filp,
> struct kobject *kobj,
> > if (!rbu_data.entry_created) {
> > spin_unlock(&rbu_data.lock);
> > req_firm_rc =
> request_firmware_nowait(THIS_MODULE,
> > -
> FW_ACTION_NOHOTPLUG,
> > + FW_ACTION_HOTPLUG,
> > "dell_rbu",
> > &rbu_device->dev,
> > GFP_KERNEL,
> >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web